Fix all remaining rubocop offenses

Author: cadamini

export_date_range.rb

@@ -1,25 +1,27 @@
 require 'date'
 
 class ExportDateRange
-  def self.for(year)
-    [start_date(year), end_date(year)]
-  end
+  class << self
+    def for(year)
+      [start_date(year), end_date(year)]
+    end
 
-  private
+    private
 
-  def self.start_date(year)
-    Date.new(year, 1, 1)
-  end
+    def start_date(year)
+      Date.new(year, 1, 1)
+    end
 
-  def self.end_date(year)
-    if this_year?(year)
-      Date.new(year, Date.today.month, Date.today.day - 1)
-    else
-      Date.new(year, 12, 31)
+    def end_date(year)
+      if this_year?(year)
+        Date.new(year, Date.today.month, Date.today.day - 1)
+      else
+        Date.new(year, 12, 31)
+      end
     end
-  end
 
-  def self.this_year?(year)
-    year == Date.today.year
+    def this_year?(year)
+      year == Date.today.year
+    end
   end
 end

holiday_client.rb

@@ -27,7 +27,8 @@ def holiday_regions
 
   def holidays_between
     Holidays.cache_between(
-      startdate, startdate.next_year(1) - 1, *holiday_regions, :informal, :observed
+      startdate, startdate.next_year(1) - 1,
+      *holiday_regions, :informal, :observed
     ).values.flatten
   end
 end

output_generator.rb

@@ -37,14 +37,20 @@ def run
 
   def output_csv_lines_for(date)
     if holiday_dates.include?(date)
-      generate_output(date, rand(12_000..13_500), distribution.special_day, distribution.special_week)
+      generate_output(
+        date, rand(12_000..13_500),
+        distribution.special_day, distribution.special_week
+      )
     else
-      generate_output(date, rand(13_500..14_500), distribution.normal_day, distribution.normal_week)
-      end
+      generate_output(date, rand(13_500..14_500),
+                      distribution.normal_day, distribution.normal_week)
+    end
   end
 
   def holiday_dates
-    dates ||= HolidayClient.new(start_date, end_date, region).holidays.map { |h| h[1] }
+    HolidayClient.new(
+      start_date, end_date, region
+    ).holidays.map { |h| h[1] }
   end
 
   private
@@ -61,16 +67,19 @@ def header
     'Queue;Date;Time;CallsOffered;CallsHandled;AHT'
   end
 
-  def generate_output(date, weekly_volume, daily_distribution, weekly_destribution)
+  def generate_output(date, weekly_volume,
+                      daily_distribution, weekly_destribution)
     daily_volume = weekly_destribution[date.wday] * weekly_volume
     daily_distribution.each_with_index do |value, interval|
-      random_value = IntervalValueRandomizer.new(daily_volume, value)
+      random = IntervalValueRandomizer.new(daily_volume, value)
       time_string = build_time_string(interval)
-      puts "#{queue_name};#{date.strftime('%d.%m.%Y')};#{time_string};#{random_value.calls};#{random_value.handled_calls};#{random_value.aht}"
+      puts "#{queue_name};#{date.strftime('%d.%m.%Y')};#{time_string};" \
+           "#{random.calls};#{random.handled_calls};#{random.aht}"
     end
   end
 
   def distribution
-    Distribution.new(open_time: @opening_hours.open, close_time: @opening_hours.close)
+    Distribution.new(open_time: @opening_hours.open,
+                     close_time: @opening_hours.close)
   end
 end

random_csv.rb

@@ -8,7 +8,7 @@ class RandomCsv
   class << self
     def generate_output
       start_date, end_date = ExportDateRange.for(first_argument_or_default_year)
-      output = OutputGenerator.new(
+      OutputGenerator.new(
         region: second_argument_or_default,
         start_date: start_date,
         end_date: end_date,

spec/script_spec.rb

@@ -3,40 +3,6 @@
 
 RSpec.describe Script do
   context 'data generation' do
-    it 'generates an array with 48 elements' do
-      expect(Script.new.base).to eq Array.new(48)
-    end
-
-    it 'knows percentages per interval' do
-      expect(Script.new.percentages).to eq [
-        0.18,
-        0.39,
-        1.36,
-        2.89,
-        4.40,
-        5.01,
-        5.22,
-        6.20,
-        6.31,
-        6.19,
-        5.94,
-        6.01,
-        5.31,
-        5.50,
-        5.34,
-        5.25,
-        4.55,
-        4.26,
-        4.22,
-        4.06,
-        3.51,
-        3.05,
-        2.59,
-        2.14,
-        0.11
-      ]
-    end
-
     it 'calculates a percentage from an input value' do
     end
   end

spec/spec_helper.rb

@@ -92,7 +92,7 @@
   #
   #   # Seed global randomization in this process using the `--seed` CLI option.
   #   # Setting this allows you to use `--seed` to deterministically reproduce
-  #   # test failures related to randomization by passing the same `--seed` value
+  #   # test failures related to randomization by passing same `--seed` value
   #   # as the one that triggered the failure.
   #   Kernel.srand config.seed
 end