(feat) change assert to require

Author: yzhang1994

.gitignore

@@ -9,4 +9,5 @@ archive/*
 coverage/*
 coverage.json
 coverageEnv/*
-.coveralls.yml
+.coveralls.yml
+DEPLOYMENT.MD

contracts/Basket.sol

@@ -103,7 +103,7 @@ contract Basket is StandardToken {
     for (uint i = 0; i < tokens.length; i++) {
       address t = tokens[i];
       uint w = weights[i];
-      assert(ERC20(t).transferFrom(msg.sender, this, w.mul(_quantity).div(10 ** decimals)));
+      require(ERC20(t).transferFrom(msg.sender, this, w.mul(_quantity).div(10 ** decimals)));
     }
 
     // charging suppliers a fee for every new basket minted
@@ -129,7 +129,7 @@ contract Basket is StandardToken {
   /// @param  _quantity                            Quantity of basket tokens to convert back to original tokens
   /// @return success                              Operation successful
   function debundleAndWithdraw(uint _quantity) public returns (bool success) {
-    assert(debundle(_quantity, msg.sender, msg.sender));
+    require(debundle(_quantity, msg.sender, msg.sender));
     emit LogDebundleAndWithdraw(msg.sender, _quantity);
     return true;
   }
@@ -185,7 +185,7 @@ contract Basket is StandardToken {
     uint bal = outstandingBalance[msg.sender][_token];
     require(bal > 0);
     outstandingBalance[msg.sender][_token] = 0;
-    assert(ERC20(_token).transfer(msg.sender, bal));
+    require(ERC20(_token).transfer(msg.sender, bal));
 
     emit LogWithdraw(msg.sender, _token, bal);
     return true;

contracts/BasketEscrow.sol

@@ -136,7 +136,7 @@ contract BasketEscrow {
     public
     returns (bool success)
   {
-    assert(ERC20(_basketAddress).transferFrom(msg.sender, this, _amountBasket));
+    require(ERC20(_basketAddress).transferFrom(msg.sender, this, _amountBasket));
     uint index = _createOrder(msg.sender, ETH_ADDRESS, _amountEth, _basketAddress, _amountBasket, _expiration, _nonce);
 
     emit LogSellOrderCreated(index, msg.sender, _basketAddress, _amountEth, _amountBasket, _expiration, _nonce);
@@ -223,7 +223,7 @@ contract BasketEscrow {
   ) public returns (bool success) {
     uint cancelledOrderIndex = _cancelOrder(msg.sender, ETH_ADDRESS, _amountEth, _basketAddress, _amountBasket, _expiration, _nonce);
 
-    assert(ERC20(_basketAddress).transfer(msg.sender, _amountBasket));
+    require(ERC20(_basketAddress).transfer(msg.sender, _amountBasket));
 
     emit LogSellOrderCancelled(cancelledOrderIndex, msg.sender, _basketAddress, _amountEth, _amountBasket);
     return true;
@@ -278,7 +278,7 @@ contract BasketEscrow {
     uint      _nonce
   ) public returns (bool success) {
     uint filledOrderIndex = _fillOrder(_orderCreator, _basketAddress, _amountBasket, ETH_ADDRESS, _amountEth, _expiration, _nonce);
-    assert(ERC20(_basketAddress).transferFrom(msg.sender, _orderCreator, _amountBasket));
+    require(ERC20(_basketAddress).transferFrom(msg.sender, _orderCreator, _amountBasket));
 
     uint fee = _amountEth.mul(transactionFee).div(10 ** FEE_DECIMALS);
     msg.sender.transfer(_amountEth.sub(fee));
@@ -303,7 +303,7 @@ contract BasketEscrow {
     uint      _nonce
   ) public payable returns (bool success) {
     uint filledOrderIndex = _fillOrder(_orderCreator, ETH_ADDRESS, msg.value, _basketAddress, _amountBasket, _expiration, _nonce);
-    assert(ERC20(_basketAddress).transfer(msg.sender, _amountBasket));
+    require(ERC20(_basketAddress).transfer(msg.sender, _amountBasket));
 
     uint fee = msg.value.mul(transactionFee).div(10 ** FEE_DECIMALS);
     _orderCreator.transfer(msg.value.sub(fee));