[LINT] error 1759

Postfix increment/decrement operator 'DynamicIDManager::operator++(int)'
returns a reference.

It's standard for C++ postfix increments to return a value instead of a
reference. The opposite is unusual at best. So instead of returning a value,
which would be rather inefficient, I've modified the code to use a prefix
increment instead, which is more in line with how C++ works in most cases.

See http://www.codeguru.com/forum/showthread.php?t=231052 (amongst many) for
more details.

Signed-off-by: Jocelyn Legault <[email protected]>

Author: joce

PythonScript/src/DynamicIDManager.cpp

@@ -68,7 +68,7 @@ idx_t DynamicIDManager::currentID()
 	return m_nextID;
 }
 
-DynamicIDManager& DynamicIDManager::operator++(int)
+DynamicIDManager& DynamicIDManager::operator++()
 {
 	// If nothing has ever been allocated
 	if (m_current == m_idList.end())

PythonScript/src/DynamicIDManager.h

@@ -33,8 +33,8 @@ class DynamicIDManager
 
 	void addBlock(idx_t start, size_t quantity);
 
-	// Post-increment operator
-	DynamicIDManager& operator++(int);
+	// Prefix increment operator
+	DynamicIDManager& operator++();
 
 
 	int capacity()   { return m_capacity; }

PythonScript/src/MenuManager.cpp

@@ -479,7 +479,7 @@ bool MenuManager::findScripts(HMENU hBaseMenu, size_t basePathLength, std::strin
 
 		++position;
 
-		(*m_scriptsMenuManager)++;
+		++(*m_scriptsMenuManager);
 
 		found = FindNextFileA(hFound, &findData);
 	}
@@ -734,7 +734,7 @@ void MenuManager::reconfigure()
 
 		}
 
-		(*m_dynamicMenuManager)++;
+		++(*m_dynamicMenuManager);
 
 		++position;
 	}
@@ -776,7 +776,7 @@ void MenuManager::configureToolbarIcons()
 		icons.hToolbarIcon = NULL;
 		m_toolbarCommands.insert(std::pair<int, std::string>(m_toolbarMenuManager->currentID(), WcharMbcsConverter::tchar2char(it->first.c_str()).get()));
 		::SendMessage(m_hNotepad, NPPM_ADDTOOLBARICON, m_toolbarMenuManager->currentID(), reinterpret_cast<LPARAM>(&icons));
-		(*m_toolbarMenuManager)++;
+		++(*m_toolbarMenuManager);
 	}
 
 }