Updated the file in response to the PR comment

Author: codeshwar-preview[bot]

core/src/main/java/com/tqdev/CrudApiHandler.java

@@ -23,24 +23,20 @@
 import com.zaxxer.hikari.HikariConfig;
 import com.zaxxer.hikari.HikariDataSource;
 import java.util.Properties;
-// Add import statement
-import java.util.*;
 
-public class CrudApiHandler extends AbstractHandler 
-{
+public class CrudApiHandler extends AbstractHandler {
   protected HikariDataSource dataSource;
-  
-  public static void main(String[] args) throws Exception
-  {
+
+  public static void main(String[] args) throws Exception {
     // jetty config
     Properties properties = new Properties();
     properties.load(CrudApiHandler.class.getClassLoader().getResourceAsStream("jetty.properties"));
     HttpConfiguration config = new HttpConfiguration();
-    config.setSendServerVersion( false );
-    HttpConnectionFactory factory = new HttpConnectionFactory( config );
+    config.setSendServerVersion(false);
+    HttpConnectionFactory factory = new HttpConnectionFactory(config);
     Server server = new Server();
-    ServerConnector connector = new ServerConnector(server,factory);
-    server.setConnectors( new Connector[] { connector } );
+    ServerConnector connector = new ServerConnector(server, factory);
+    server.setConnectors(new Connector[] {connector});
     connector.setHost(properties.getProperty("host"));
     connector.setPort(Integer.parseInt(properties.getProperty("port")));
     server.addConnector(connector);
@@ -49,13 +45,11 @@ public static void main(String[] args) throws Exception
     server.join();
   }
 
-  public CrudApiHandler() throws IOException
-  {
+  public CrudApiHandler() throws IOException {
     this.dataSource = this.getDataSource();
   }
 
-  protected HikariDataSource getDataSource()
-  {
+  protected HikariDataSource getDataSource() {
     HikariDataSource dataSource;
     try {
       Properties properties = new Properties();
@@ -68,8 +62,7 @@ protected HikariDataSource getDataSource()
     return dataSource;
   }
 
-  protected Connection getConnection()
-  {
+  protected Connection getConnection() {
     Connection link;
     try {
       link = this.dataSource.getConnection();
@@ -80,46 +73,45 @@ protected Connection getConnection()
     return link;
   }
 
-  public void handle(String target,Request baseReq,HttpServletRequest req,HttpServletResponse resp) 
-        throws IOException, ServletException
-  {
+  public void handle(String target, Request baseReq, HttpServletRequest req, HttpServletResponse resp)
+      throws IOException, ServletException {
     Gson gson = new Gson();
     // get the HTTP method, path and body of the request
     String method = req.getMethod();
-    String[] request = req.getPathInfo().replaceAll("/$|^/","").split("/");
+    String[] request = req.getPathInfo().replaceAll("/$|^/", "").split("/");
     @SuppressWarnings("unchecked")
     Map<String, Object> input = gson.fromJson(req.getReader(), Map.class);
     // connect to the mysql database
     Connection link = this.getConnection();
     // retrieve the table and key from the path
-    String table = request[0].replaceAll("[^a-zA-Z0-9_]+","");
-    int key = (request.length>1?Integer.parseInt(request[1]):-1);
+    String table = request[0].replaceAll("[^a-zA-Z0-9_]+", "");
+    int key = (request.length > 1 ? Integer.parseInt(request[1]) : -1);
     // escape the columns and values from the input object
-    String[] columns = input==null?(new String[0]):(String[])input.keySet().toArray();
-    for (int i=0;i<columns.length;i++) {
-      columns[i] = columns[i].replaceAll("[^a-zA-Z0-9_]+","");
+    String[] columns = input == null ? (new String[0]) : (String[]) input.keySet().toArray();
+    for (int i = 0; i < columns.length; i++) {
+      columns[i] = columns[i].replaceAll("[^a-zA-Z0-9_]+", "");
     }
     // build the SET part of the SQL command
     String set = "";
-    for (int i=0;i<columns.length;i++) {
-      set+=(i>0?",":"")+"`"+columns[i]+"`=?";
+    for (int i = 0; i < columns.length; i++) {
+      set += (i > 0 ? "," : "") + "`" + columns[i] + "`=?";
     }
     // create SQL based on HTTP method
-    String sql="";
+    String sql = "";
     if (method.equals("GET")) {
-        sql = "select * from `"+table+"`"+(key>0?" WHERE id="+key:"");
+      sql = "select * from `" + table + "`" + (key > 0 ? " WHERE id=" + key : "");
     } else if (method.equals("PUT")) {
-        sql = "update `"+table+"` set "+set+" where id="+key;
+      sql = "update `" + table + "` set " + set + " where id=" + key;
     } else if (method.equals("POST")) {
-        sql = "insert into `"+table+"` set "+set;
+      sql = "insert into `" + table + "` set " + set;
     } else if (method.equals("DELETE")) {
-        sql = "delete `"+table+"` where id="+key;
+      sql = "delete from `" + table + "` where id=" + key;
     }
-    PreparedStatement statement=null;
+    PreparedStatement statement = null;
     try {
       // execute SQL statement
       statement = link.prepareStatement(sql);
-      for (int i=0;i<columns.length;i++) {
+      for (int i = 0; i < columns.length; i++) {
         statement.setObject(i, input.get(columns[i]));
       }
       // print results, insert id or affected row count
@@ -130,37 +122,47 @@ public void handle(String target,Request baseReq,HttpServletRequest req,HttpServ
         ResultSet result = statement.executeQuery();
         ResultSetMetaData meta = result.getMetaData();
         int colCount = meta.getColumnCount();
-        if (key<0) w.print('[');
-        int row=0;
+        if (key < 0)
+          w.print('[');
+        int row = 0;
         while (result.next()) {
-          if (row>0) w.print(',');
+          if (row > 0)
+            w.print(',');
           w.print('{');
-          for (int col=1;col<=colCount;col++) {
-            if (col>1) w.print(',');
+          for (int col = 1; col <= colCount; col++) {
+            if (col > 1)
+              w.print(',');
             w.print(gson.toJson(meta.getColumnName(col)));
             w.print(':');
             w.print(gson.toJson(result.getObject(col)));
           }
           w.print('}');
           row++;
         }
-        if (key<0) w.print(']');
+        if (key < 0)
+          w.print(']');
       } else if (method.equals("POST")) {
-        statement.executeUpdate(sql);
+        statement.executeUpdate();
         ResultSet result = statement.getGeneratedKeys();
         result.next();
         w.print(gson.toJson(result.getObject(1)));
       } else {
-        w.print(gson.toJson(statement.executeUpdate(sql)));
+        w.print(gson.toJson(statement.executeUpdate()));
       }
-    }
-    catch (SQLException e) {
-      System.out.println("SQLException:"+e);
-    }
-    finally {
+    } catch (SQLException e) {
+      System.out.println("SQLException:" + e);
+    } finally {
       // close mysql connection
-      if (statement != null) try { statement.close(); } catch (SQLException ignore) {}
-      if (link != null) try { link.close(); } catch (SQLException ignore) {}
+      if (statement != null)
+        try {
+          statement.close();
+        } catch (SQLException ignore) {
+        }
+      if (link != null)
+        try {
+          link.close();
+        } catch (SQLException ignore) {
+        }
     }
     baseReq.setHandled(true);
   }