Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chrismoultonsf/plotly.py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: chrismoultonsf/plotly.py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: test-jupyter-circleci-squashed
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 13 files changed
  • 1 contributor

Commits on Aug 18, 2016

  1. first pass js jupyter tests

    @etpinard
    etpinard committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    1cb34f3 View commit details
    Browse the repository at this point in the history

  2. un-ignore fixture ipynb files

    @etpinard
    etpinard committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    160cadb View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2016

  1. standardize optional requirements for CircleCI 

    - add coverage to optional requirements
- pip install optional requirements and no need for
  nothing else
    @etpinard
    etpinard committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    0b84f31 View commit details
    Browse the repository at this point in the history

  2. add requirements for jupyter test on circleci

    @etpinard
    etpinard committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    0d9d3ae View commit details
    Browse the repository at this point in the history

  3. improve jupyter test design: 

    - make lib/server.js handle arbitrary html index and js test file
  (to test multiple ipynb fixutres)
- use ipykernel to determine which python version nosetest is launched w/
- use domready to make sure that tests are ran after DOM is ready
    @etpinard
    etpinard committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    2b09021 View commit details
    Browse the repository at this point in the history

  4. split ipynb fixture and js test file into two cases: 

    - one testing offline connected=True
- one testing offline connected=False (the default)
    @etpinard
    etpinard committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    dc1811d View commit details
    Browse the repository at this point in the history
Loading