Skip to content

Commit a14234d

Browse files
authored
ci: Fix java feature server Dockerfile to use updated builder (feast-dev#3152)
Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Achal Shah <[email protected]>
1 parent 50e8755 commit a14234d

File tree

4 files changed

+32
-29
lines changed

4 files changed

+32
-29
lines changed

go/embedded/online_features.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -378,12 +378,12 @@ func (s *OnlineFeatureService) StopGrpcServer() {
378378
}
379379

380380
/*
381-
Read Record Batch from memory managed by Python caller.
382-
Python part uses C ABI interface to export this record into C Data Interface,
383-
and then it provides pointers (dataPtr & schemaPtr) to the Go part.
384-
Here we import this data from given pointers and wrap the underlying values
385-
into Go Arrow Interface (array.Record).
386-
See export code here https://github.com/feast-dev/feast/blob/master/sdk/python/feast/embedded_go/online_features_service.py
381+
Read Record Batch from memory managed by Python caller.
382+
Python part uses C ABI interface to export this record into C Data Interface,
383+
and then it provides pointers (dataPtr & schemaPtr) to the Go part.
384+
Here we import this data from given pointers and wrap the underlying values
385+
into Go Arrow Interface (array.Record).
386+
See export code here https://github.com/feast-dev/feast/blob/master/sdk/python/feast/embedded_go/online_features_service.py
387387
*/
388388
func readArrowRecord(data DataTable) (arrow.Record, error) {
389389
return cdata.ImportCRecordBatch(

go/internal/feast/onlineserving/serving.go

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ import (
2121
)
2222

2323
/*
24-
FeatureVector type represent result of retrieving single feature for multiple rows.
25-
It can be imagined as a column in output dataframe / table.
26-
It contains of feature name, list of values (across all rows),
27-
list of statuses and list of timestamp. All these lists have equal length.
28-
And this length is also equal to number of entity rows received in request.
24+
FeatureVector type represent result of retrieving single feature for multiple rows.
25+
It can be imagined as a column in output dataframe / table.
26+
It contains of feature name, list of values (across all rows),
27+
list of statuses and list of timestamp. All these lists have equal length.
28+
And this length is also equal to number of entity rows received in request.
2929
*/
3030
type FeatureVector struct {
3131
Name string
@@ -40,11 +40,11 @@ type FeatureViewAndRefs struct {
4040
}
4141

4242
/*
43-
We group all features from a single request by entities they attached to.
44-
Thus, we will be able to call online retrieval per entity and not per each feature View.
45-
In this struct we collect all features and views that belongs to a group.
46-
We also store here projected entity keys (only ones that needed to retrieve these features)
47-
and indexes to map result of retrieval into output response.
43+
We group all features from a single request by entities they attached to.
44+
Thus, we will be able to call online retrieval per entity and not per each feature View.
45+
In this struct we collect all features and views that belongs to a group.
46+
We also store here projected entity keys (only ones that needed to retrieve these features)
47+
and indexes to map result of retrieval into output response.
4848
*/
4949
type GroupedFeaturesPerEntitySet struct {
5050
// A list of requested feature references of the form featureViewName:featureName that share this entity set
@@ -59,11 +59,12 @@ type GroupedFeaturesPerEntitySet struct {
5959
}
6060

6161
/*
62-
Return
63-
(1) requested feature views and features grouped per View
64-
(2) requested on demand feature views
65-
existed in the registry
62+
Return
6663
64+
(1) requested feature views and features grouped per View
65+
(2) requested on demand feature views
66+
67+
existed in the registry
6768
*/
6869
func GetFeatureViewsToUseByService(
6970
featureService *model.FeatureService,
@@ -124,10 +125,12 @@ func GetFeatureViewsToUseByService(
124125
}
125126

126127
/*
127-
Return
128-
(1) requested feature views and features grouped per View
129-
(2) requested on demand feature views
130-
existed in the registry
128+
Return
129+
130+
(1) requested feature views and features grouped per View
131+
(2) requested on demand feature views
132+
133+
existed in the registry
131134
*/
132135
func GetFeatureViewsToUseByFeatureRefs(
133136
features []string,

go/internal/feast/transformation/transformation.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ import (
2020
)
2121

2222
/*
23-
TransformationCallback is a Python callback function's expected signature.
24-
The function should accept name of the on demand feature view and pointers to input & output record batches.
25-
Each record batch is being passed as two pointers: pointer to array (data) and pointer to schema.
26-
Python function is expected to return number of rows added to the output record batch.
23+
TransformationCallback is a Python callback function's expected signature.
24+
The function should accept name of the on demand feature view and pointers to input & output record batches.
25+
Each record batch is being passed as two pointers: pointer to array (data) and pointer to schema.
26+
Python function is expected to return number of rows added to the output record batch.
2727
*/
2828
type TransformationCallback func(ODFVName string, inputArrPtr, inputSchemaPtr, outArrPtr, outSchemaPtr uintptr, fullFeatureNames bool) int
2929

java/infra/docker/feature-server/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Build stage 1: Builder
33
# ============================================================
44

5-
FROM maven:3.6-jdk-11 as builder
5+
FROM maven:3-jdk-11 as builder
66

77
WORKDIR /build
88

0 commit comments

Comments
 (0)