Add a note about "tzdata", adjust configuration appropriately, and remove fetch deps too

Author: tianon

9.2/alpine/Dockerfile

@@ -98,13 +98,18 @@ RUN set -ex \
 		$runDeps \
 		bash \
 		su-exec \
-	&& apk del .build-deps \
+# tzdata loading functionality is optional, and fails gracefully
+#		tzdata \
+	&& apk del .fetch-deps .build-deps \
 	&& cd / \
 	&& rm -rf \
 		/usr/src/postgresql \
 		/usr/local/include/* \
 	&& find /usr/local -name '*.a' -delete
 
+# make the sample config easier to munge (and "correct by default")
+RUN sed -ri "s!^#?(listen_addresses)\s*=\s*\S+.*!\1 = '*'!" /usr/local/share/postgresql/postgresql.conf.sample
+
 RUN mkdir -p /var/run/postgresql && chown -R postgres /var/run/postgresql
 
 ENV PATH /usr/lib/postgresql/$PG_MAJOR/bin:$PATH

9.3/alpine/Dockerfile

@@ -98,13 +98,18 @@ RUN set -ex \
 		$runDeps \
 		bash \
 		su-exec \
-	&& apk del .build-deps \
+# tzdata loading functionality is optional, and fails gracefully
+#		tzdata \
+	&& apk del .fetch-deps .build-deps \
 	&& cd / \
 	&& rm -rf \
 		/usr/src/postgresql \
 		/usr/local/include/* \
 	&& find /usr/local -name '*.a' -delete
 
+# make the sample config easier to munge (and "correct by default")
+RUN sed -ri "s!^#?(listen_addresses)\s*=\s*\S+.*!\1 = '*'!" /usr/local/share/postgresql/postgresql.conf.sample
+
 RUN mkdir -p /var/run/postgresql && chown -R postgres /var/run/postgresql
 
 ENV PATH /usr/lib/postgresql/$PG_MAJOR/bin:$PATH

9.4/alpine/Dockerfile

@@ -98,13 +98,18 @@ RUN set -ex \
 		$runDeps \
 		bash \
 		su-exec \
-	&& apk del .build-deps \
+# tzdata loading functionality is optional, and fails gracefully
+#		tzdata \
+	&& apk del .fetch-deps .build-deps \
 	&& cd / \
 	&& rm -rf \
 		/usr/src/postgresql \
 		/usr/local/include/* \
 	&& find /usr/local -name '*.a' -delete
 
+# make the sample config easier to munge (and "correct by default")
+RUN sed -ri "s!^#?(listen_addresses)\s*=\s*\S+.*!\1 = '*'!" /usr/local/share/postgresql/postgresql.conf.sample
+
 RUN mkdir -p /var/run/postgresql && chown -R postgres /var/run/postgresql
 
 ENV PATH /usr/lib/postgresql/$PG_MAJOR/bin:$PATH

9.5/alpine/Dockerfile

@@ -98,13 +98,18 @@ RUN set -ex \
 		$runDeps \
 		bash \
 		su-exec \
-	&& apk del .build-deps \
+# tzdata loading functionality is optional, and fails gracefully
+#		tzdata \
+	&& apk del .fetch-deps .build-deps \
 	&& cd / \
 	&& rm -rf \
 		/usr/src/postgresql \
 		/usr/local/include/* \
 	&& find /usr/local -name '*.a' -delete
 
+# make the sample config easier to munge (and "correct by default")
+RUN sed -ri "s!^#?(listen_addresses)\s*=\s*\S+.*!\1 = '*'!" /usr/local/share/postgresql/postgresql.conf.sample
+
 RUN mkdir -p /var/run/postgresql && chown -R postgres /var/run/postgresql
 
 ENV PATH /usr/lib/postgresql/$PG_MAJOR/bin:$PATH

9.6/alpine/Dockerfile

@@ -98,13 +98,18 @@ RUN set -ex \
 		$runDeps \
 		bash \
 		su-exec \
-	&& apk del .build-deps \
+# tzdata loading functionality is optional, and fails gracefully
+#		tzdata \
+	&& apk del .fetch-deps .build-deps \
 	&& cd / \
 	&& rm -rf \
 		/usr/src/postgresql \
 		/usr/local/include/* \
 	&& find /usr/local -name '*.a' -delete
 
+# make the sample config easier to munge (and "correct by default")
+RUN sed -ri "s!^#?(listen_addresses)\s*=\s*\S+.*!\1 = '*'!" /usr/local/share/postgresql/postgresql.conf.sample
+
 RUN mkdir -p /var/run/postgresql && chown -R postgres /var/run/postgresql
 
 ENV PATH /usr/lib/postgresql/$PG_MAJOR/bin:$PATH

Dockerfile-alpine.template

@@ -98,13 +98,18 @@ RUN set -ex \
 		$runDeps \
 		bash \
 		su-exec \
-	&& apk del .build-deps \
+# tzdata loading functionality is optional, and fails gracefully
+#		tzdata \
+	&& apk del .fetch-deps .build-deps \
 	&& cd / \
 	&& rm -rf \
 		/usr/src/postgresql \
 		/usr/local/include/* \
 	&& find /usr/local -name '*.a' -delete
 
+# make the sample config easier to munge (and "correct by default")
+RUN sed -ri "s!^#?(listen_addresses)\s*=\s*\S+.*!\1 = '*'!" /usr/local/share/postgresql/postgresql.conf.sample
+
 RUN mkdir -p /var/run/postgresql && chown -R postgres /var/run/postgresql
 
 ENV PATH /usr/lib/postgresql/$PG_MAJOR/bin:$PATH