Skip to content

Commit da8a319

Browse files
committed
HADOOP-7129. Fix typo in method name getProtocolSigature. Contributed by Todd Lipcon.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1066248 13f79535-47bb-0310-9956-ffa450edef68
1 parent 863dc3b commit da8a319

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ Trunk (unreleased changes)
6161
HADOOP-6939. Inconsistent lock ordering in
6262
AbstractDelegationTokenSecretManager. (Todd Lipcon via tomwhite)
6363

64+
HADOOP-7129. Fix typo in method name getProtocolSigature (todd)
65+
6466
Release 0.22.0 - Unreleased
6567

6668
INCOMPATIBLE CHANGES

src/java/org/apache/hadoop/ipc/ProtocolSignature.java

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ static ProtocolSignature getProtocolSignature(
225225
* @throws IOException if any error occurs
226226
*/
227227
@SuppressWarnings("unchecked")
228-
public static ProtocolSignature getProtocolSigature(VersionedProtocol server,
228+
public static ProtocolSignature getProtocolSignature(VersionedProtocol server,
229229
String protocol,
230230
long clientVersion, int clientMethodsHash) throws IOException {
231231
Class<? extends VersionedProtocol> inter;
@@ -238,4 +238,16 @@ public static ProtocolSignature getProtocolSigature(VersionedProtocol server,
238238
return ProtocolSignature.getProtocolSignature(
239239
clientMethodsHash, serverVersion, inter);
240240
}
241-
}
241+
242+
/**
243+
* @deprecated Misspelled method name - to be removed after references
244+
* to this typo have been fixed in HDFS and MapRed.
245+
*/
246+
@Deprecated
247+
public static ProtocolSignature getProtocolSigature(VersionedProtocol server,
248+
String protocol,
249+
long clientVersion, int clientMethodsHash) throws IOException {
250+
return getProtocolSignature(server, protocol, clientVersion,
251+
clientMethodsHash);
252+
}
253+
}

src/java/org/apache/hadoop/ipc/VersionedProtocol.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public long getProtocolVersion(String protocol,
4545
* @param clientMethodsHash the hashcode of client protocol methods
4646
* @return the server protocol signature containing its version and
4747
* a list of its supported methods
48-
* @see ProtocolSignature#getProtocolSigature(VersionedProtocol, String,
48+
* @see ProtocolSignature#getProtocolSignature(VersionedProtocol, String,
4949
* long, int) for a default implementation
5050
*/
5151
public ProtocolSignature getProtocolSignature(String protocol,

0 commit comments

Comments
 (0)