Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudflare/quiche
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: cloudflare/quiche
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: akothari/reorder_agressive_disable
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 28, 2025

  1. fix: adjust time-based loss detection threshold on packet reordering 

    Dynamic time threshold logic from
#470 was accidentally removed.

The goal is to make time-based detection less sensitive when a spurious
loss is detected.
    @toidiu
    toidiu committed Aug 28, 2025
    Configuration menu
    Copy the full SHA
    8ae7ae1 View commit details
    Browse the repository at this point in the history

  2. refactor: cleanup test

    @toidiu
    toidiu committed Aug 28, 2025
    Configuration menu
    Copy the full SHA
    ecc2a85 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2025

  1. fix: fix spurious count logic in gcongestion and add test. 

    Recovery logic was returning the wrong spurious loss count if no
new packets were acked. This fixes the bug.

I also added a new test for time-based loss detection, specifically
testing that the value increases after a spurious loss event.
    @toidiu
    toidiu committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    5eabddd View commit details
    Browse the repository at this point in the history

  2. disable pkt threshold based loss detection

    @toidiu
    toidiu committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    604314f View commit details
    Browse the repository at this point in the history

  3. on spurious loss: disable pkt thresh. Then double time thresh on subs… 

    …equent spurious loss.
    @toidiu
    toidiu committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    c449990 View commit details
    Browse the repository at this point in the history
Loading