Skip to content

Commit 3012782

Browse files
authored
Merge pull request #1715 from cloudwego/release-v0.12.3
chore: release v0.12.3
2 parents a53a472 + 5ff29fd commit 3012782

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ require (
99
github.com/cloudwego/dynamicgo v0.5.2
1010
github.com/cloudwego/fastpb v0.0.5
1111
github.com/cloudwego/frugal v0.2.3
12-
github.com/cloudwego/gopkg v0.1.4-0.20241217093255-8980b14172b7
12+
github.com/cloudwego/gopkg v0.1.4
1313
github.com/cloudwego/localsession v0.1.2
1414
github.com/cloudwego/netpoll v0.6.5
1515
github.com/cloudwego/runtimex v0.1.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ github.com/cloudwego/fastpb v0.0.5 h1:vYnBPsfbAtU5TVz5+f9UTlmSCixG9F9vRwaqE0mZPZ
2121
github.com/cloudwego/fastpb v0.0.5/go.mod h1:Bho7aAKBUtT9RPD2cNVkTdx4yQumfSv3If7wYnm1izk=
2222
github.com/cloudwego/frugal v0.2.3 h1:t1hhhAi8lXcx7Ncs4PR1pSZ90vlDU1cy5K2btDMFpoA=
2323
github.com/cloudwego/frugal v0.2.3/go.mod h1:nC1U47gswLRiaxv6dybrhZvsDGCfQP9RGiiWC73CnoI=
24-
github.com/cloudwego/gopkg v0.1.4-0.20241217093255-8980b14172b7 h1:RmKES3lXoM62rUVEEy0teTsPYNBtFpqSN1lYBw4v82g=
25-
github.com/cloudwego/gopkg v0.1.4-0.20241217093255-8980b14172b7/go.mod h1:FQuXsRWRsSqJLsMVd5SYzp8/Z1y5gXKnVvRrWUOsCMI=
24+
github.com/cloudwego/gopkg v0.1.4 h1:EoQiCG4sTonTPHxOGE0VlQs+sQR+Hsi2uN0qqwu8O50=
25+
github.com/cloudwego/gopkg v0.1.4/go.mod h1:FQuXsRWRsSqJLsMVd5SYzp8/Z1y5gXKnVvRrWUOsCMI=
2626
github.com/cloudwego/iasm v0.2.0 h1:1KNIy1I1H9hNNFEEH3DVnI4UujN+1zjpuk6gwHLTssg=
2727
github.com/cloudwego/iasm v0.2.0/go.mod h1:8rXZaNYT2n95jn+zTI1sDr+IgcD2GVs0nlbbQPiEFhY=
2828
github.com/cloudwego/localsession v0.1.2 h1:RBmeLDO5sKr4ujd8iBp5LTMmuVKLdu88jjIneq/fEZ8=

tool/cmd/kitex/main.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,10 @@ func main() {
103103
}
104104

105105
if args.IDLType == "thrift" && !args.LocalThriftgo {
106-
err = sdk.InvokeThriftgoBySDK(curpath, cmd)
106+
if err = sdk.InvokeThriftgoBySDK(curpath, cmd); err != nil {
107+
// todo: optimize -use and remove error returned from thriftgo
108+
out.WriteString(err.Error())
109+
}
107110
} else {
108111
err = kargs.ValidateCMD(cmd.Path, args.IDLType)
109112
if err != nil {

tool/internal_pkg/tpl/service.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ func newServiceInfo(hasStreaming bool, keepStreamingMethods bool, keepNonStreami
144144
return svcInfo
145145
}
146146
147+
{{- $referToKitexServerInterface := and .StreamX .HasStreaming}}
147148
{{range .AllMethods}}
148149
{{- $isStreaming := or .ClientStreaming .ServerStreaming}}
149150
{{- $streamingUnary := (eq .StreamingMode "unary")}}
@@ -153,6 +154,10 @@ func newServiceInfo(hasStreaming bool, keepStreamingMethods bool, keepNonStreami
153154
{{- $bidiSide := and .ClientStreaming .ServerStreaming}}
154155
{{- $arg := ""}}
155156
{{- $handlerFunc := ""}}
157+
{{- $serverInterfaceName := printf "%s.%s" .PkgRefName .ServiceName }}
158+
{{- if $referToKitexServerInterface}}
159+
{{- $serverInterfaceName = .ServiceName}}{{/* when streamx is enabled and there are streaming methods, refer to Server Interface defined in service/server.go */}}
160+
{{- end}}
156161
{{- $mode := ""}}
157162
{{- if $streamingUnary -}} {{- $mode = "serviceinfo.StreamingUnary" }} {{- $handlerFunc = "InvokeUnaryHandler" }}
158163
{{- else if $serverSide -}} {{- $mode = "serviceinfo.StreamingServer" }} {{- $handlerFunc = "InvokeServerStreamHandler" }}
@@ -228,8 +233,8 @@ func {{LowerFirst .Name}}Handler(ctx context.Context, handler interface{}, arg,
228233
{{- end}}
229234
{{if gt .ArgsLength 0}}realArg := {{else}}_ = {{end}}arg.(*{{if not .GenArgResultStruct}}{{.PkgRefName}}.{{end}}{{.ArgStructName}})
230235
{{if or (not .Void) .Exceptions}}realResult := result.(*{{if not .GenArgResultStruct}}{{.PkgRefName}}.{{end}}{{.ResStructName}}){{end}}
231-
{{if .Void}}err := handler.({{.PkgRefName}}.{{.ServiceName}}).{{.Name}}(ctx{{range .Args}}, realArg.{{.Name}}{{end}})
232-
{{else}}success, err := handler.({{.PkgRefName}}.{{.ServiceName}}).{{.Name}}(ctx{{range .Args}}, realArg.{{.Name}}{{end}})
236+
{{if .Void}}err := handler.({{$serverInterfaceName}}).{{.Name}}(ctx{{range .Args}}, realArg.{{.Name}}{{end}})
237+
{{else}}success, err := handler.({{$serverInterfaceName}}).{{.Name}}(ctx{{range .Args}}, realArg.{{.Name}}{{end}})
233238
{{end -}}
234239
if err != nil {
235240
{{- if $HandlerReturnKeepResp }}

version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ package kitex
1919
// Name and Version info of this framework, used for statistics and debug
2020
const (
2121
Name = "Kitex"
22-
Version = "v0.12.2"
22+
Version = "v0.12.3"
2323
)

0 commit comments

Comments
 (0)