Merge pull request nextcloud#8053 from nextcloud/simplify-substr

Use short for of substr to not need strlen()

Author: nickvergessen

apps/files_versions/lib/Storage.php

@@ -167,7 +167,7 @@ public static function store($filename) {
 		// to get the right target
 		$ext = pathinfo($filename, PATHINFO_EXTENSION);
 		if ($ext === 'part') {
-			$filename = substr($filename, 0, strlen($filename) - 5);
+			$filename = substr($filename, 0, -5);
 		}
 
 		// we only handle existing files

lib/private/DB/Adapter.php

@@ -108,7 +108,7 @@ public function insertIfNotExist($table, $input, array $compare = null) {
 				$query .= ' = ? AND ';
 			}
 		}
-		$query = substr($query, 0, strlen($query) - 5);
+		$query = substr($query, 0, -5);
 		$query .= ' HAVING COUNT(*) = 0';
 
 		return $this->conn->executeUpdate($query, $inserts);

lib/private/DB/AdapterSqlite.php

@@ -79,7 +79,7 @@ public function insertIfNotExist($table, $input, array $compare = null) {
 				$query .= ' = ? AND ';
 			}
 		}
-		$query = substr($query, 0, strlen($query) - 5);
+		$query = substr($query, 0, -5);
 		$query .= ')';
 
 		return $this->conn->executeUpdate($query, $inserts);

lib/private/legacy/template.php

@@ -132,7 +132,7 @@ public static function initTemplateEngine($renderAs) {
 					foreach(array_reverse($coreDependencies['vendor']) as $vendorLibrary) {
 						//remove trailing ".js" as addVendorScript will append it
 						OC_Util::addVendorScript(
-							substr($vendorLibrary, 0, strlen($vendorLibrary) - 3),null,true);
+							substr($vendorLibrary, 0, -3),null,true);
 						}
  				} else {
 					throw new \Exception('Cannot read core/js/core.json');