Remove loader.on_task_return, replace with loader.on_process_cleanup

Author: Ask Solem

celery/loaders/base.py

@@ -28,7 +28,7 @@ def on_task_init(self, task_id, task):
         """This method is called before a task is executed."""
         pass
 
-    def on_task_return(self, task_id, task, status, retval):
+    def on_process_cleanup(self):
         """This method is called after a task is executed."""
         pass
 

celery/tests/test_worker_job.py

@@ -175,10 +175,7 @@ def test_execute_does_not_execute_revoked(self):
 
     def test_execute_acks_late(self):
         mytask_raising.acks_late = True
-        tw = TaskRequest(mytask_raising.name, gen_unique_id(), [1], {"f": "x"})
         try:
-            tw.execute()
-            self.assertTrue(tw.acknowledged)
         finally:
             mytask_raising.acks_late = False
 

celery/worker/job.py

@@ -100,17 +100,14 @@ def execute(self):
             return super(WorkerTaskTrace, self).execute()
         finally:
             self.task.backend.process_cleanup()
+            self.loader.on_process_cleanup()
 
     def handle_success(self, retval, *args):
         """Handle successful execution."""
         if not self.task.ignore_result:
             self.task.backend.mark_as_done(self.task_id, retval)
         return self.super.handle_success(retval, *args)
 
-    def handle_after_return(self, status, retval, type_, tb, strtb):
-        self.loader.on_task_return(self.task_id, self.task, status, retval)
-        self.super.handle_after_return(status, retval, type_, tb, strtb)
-
     def handle_retry(self, exc, type_, tb, strtb):
         """Handle retry exception."""
         message, orig_exc = exc.args