Skip to content

Commit 284b445

Browse files
committed
scope the node path check
Since the anvil service which Travis uses is built using node and anvil leaks its path into the build enviroment, node is always on the path, so `node_js_installed?` will always return true. This executes the direct binary skipping the PATH completely.
1 parent 64872fa commit 284b445

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/language_pack/ruby.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ def node_bp_bin_path
693693
end
694694

695695
def node_js_installed?
696-
@node_js_installed ||= run("node -v", env: {"PATH" => "#{node_bp_bin_path}:#{ENV["PATH"]}" }) && $?.success?
696+
@node_js_installed ||= run("#{node_bp_bin_path}/node -v") && $?.success?
697697
end
698698

699699
def run_assets_precompile_rake_task

0 commit comments

Comments
 (0)