Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: commitmoji/pgtoolsservice
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: commitmoji/pgtoolsservice
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: kevin/mysql-aadauth-tests
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 433 files changed
  • 9 contributors

Commits on Jul 9, 2019

  1. Refactored the ConnectionService class to connect to MySQL in additio…

    …n to PG (microsoft#213)
    
    * created ServerConnection and DriverManager wrapper classes. Currently moving psycopg and PG specific logic into respective connection class
    
    * removing references to psycopg2 outside of the ServerConnection and maintaining the abstraction
    
    * can connect to MySQL now
    
    * moved ServerConnection class to the connection service module
    
    * fixed error due to circular import dependencies, had to move driver.py to pgtools utils
    
    * modularized the driver components, seperated the driver implementations into seperate files for ease
    
    * started implementing the pymysql driver class for connectivity
    
    * changed place where we determine provider
    
    * quick fix: fixed errors in psycopg driver class
    
    * renamed DriverManager, removed dsn_parameters method, added constants, addressed comments
    
    * used constants instead of strings in main.py
    sasank-chaganty authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ab30a0a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. adding MySQL SMO, refactoring OE, scripting, and querying services (m…

    …icrosoft#214)
    
    * refactored admin service to be multi-provider
    
    * SMO reorganization (microsoft#216)
    
    * Moved all server-specific functions from object_finder.py into pgsmo server class and removed the file.
    * Removed all references and import statements that pointed to object_finder
    * Moved pgsmo utils and node object implementation to common smo folder (to be used by both MySQL_smo + pgsmo). Modified the import statements of many files to point to the new smo folder.
    * Added boilerplate code and folders for every object in mysqlsmo
    * Split routing.py into two files to encapsulate the MySQL routing and node generator logic.
    * Created MySQL routing table in MySQL_routing.py
    
    * refactored metadata service, added new metadata query for MySQL
    
    * added generator functions to routing and added properties to access template paths of SMO objects
    
    * OE base nodes and databases Folders show up
    
    * databases, users, and charsets are expanding
    
    * events, functions, and stored procedures are not expanding, everything else seems to be expanding
    
    * refactored admin + metadata services, added constraints to SMO
    
    * prepping for demo
    
    * refactored scripting and querying (microsoft#217)
    
    * CREATE Script works for Tables and Views
    * refactored capabilities service, allowed users to specify port numbers
    * added converters for MySQL
    * refactored querying service
    * querying seems to work through the notebooks
    * changes to retain compatibility with the Postgres extension
    
    * added statements to revive connection if dropped
    
    * removing null reference to dbname in sql statements for events
    
    * small edits to build settings
    
    * corrected misspelled file names
    
    * deleted misspelled files
    
    * server and database details show up on the dashboard
    
    * corrected regex expression to extract username
    sasank-chaganty authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    947063d View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Add multi-provider support and update to master (microsoft#241)

    * refactored admin service to be multi-provider
    
    * SMO reorganization (microsoft#216)
    
    * Moved all server-specific functions from object_finder.py into pgsmo server class and removed the file.
    * Removed all references and import statements that pointed to object_finder
    * Moved pgsmo utils and node object implementation to common smo folder (to be used by both MySQL_smo + pgsmo). Modified the import statements of many files to point to the new smo folder.
    * Added boilerplate code and folders for every object in mysqlsmo
    * Split routing.py into two files to encapsulate the MySQL routing and node generator logic.
    * Created MySQL routing table in MySQL_routing.py
    
    * refactored metadata service, added new metadata query for MySQL
    
    * added generator functions to routing and added properties to access template paths of SMO objects
    
    * OE base nodes and databases Folders show up
    
    * databases, users, and charsets are expanding
    
    * events, functions, and stored procedures are not expanding, everything else seems to be expanding
    
    * refactored admin + metadata services, added constraints to SMO
    
    * prepping for demo
    
    * refactored scripting and querying (microsoft#217)
    
    * CREATE Script works for Tables and Views
    * refactored capabilities service, allowed users to specify port numbers
    * added converters for MySQL
    * refactored querying service
    * querying seems to work through the notebooks
    * changes to retain compatibility with the Postgres extension
    
    * added statements to revive connection if dropped
    
    * removing null reference to dbname in sql statements for events
    
    * small edits to build settings
    
    * corrected misspelled file names
    
    * deleted misspelled files
    
    * server and database details show up on the dashboard
    
    * corrected regex expression to extract username
    
    * Fix for No file corresponding to the given URI (microsoft#219)
    
    * unquoting the file uri before its is used as a key for the opened files
    
    * Updated missing changes to handle pop and get and search
    
    * Deploy changes (microsoft#224)
    
    * Changes for dpeloy
    
    Adding deploy apis
    
    * Remove tlc changes
    
    * Fixing some build issues
    
    * Rename execute_deploy_string_request to execute_deploy_request
    
    * Fix for skipping intellisense for non pgsql language flavor
    
    We are directly using the text document uri which is encoded, hence now using the decoded url which is by using file_url from script file.
    
    Similar fix to mssql extension: microsoft/sqltoolsservice#910
    
    * Add tests for deploy request
    
    * Revert "Fix for skipping intellisense for non pgsql language flavor"
    
    This reverts commit 2aea459.
    
    * Fix for skipping intellisense for non pgsql language flavor (microsoft#229)
    
    We are directly using the text document uri which is encoded, hence now using the decoded url which is by using file_url from script file.
    
    Similar fix to mssql extension: microsoft/sqltoolsservice#910
    
    * Add ability for service to accept azureAccountToken from ADS client (microsoft#221)
    
    * Code changes for AAD
    
    * Fix check for key present in dict
    
    * Add unit test to make sure account token is passed as PostgreSQL password.
    
    * Remove extra import added by mistake.
    
    * Fix static analysis errors
    
    * Handling null for tsrange and numrange queries (microsoft#231)
    
    * Changes to build pgtoolsservice
    
    * Update converters to handle null
    
    * Revert "Changes to build pgtoolsservice"
    
    This reverts commit 8abf970.
    
    * Use original unformatted query text for execution (microsoft#234)
    
    * use original unformatted query text for execution
    
    * fix whitespace
    
    * do not convert json returned by the server (microsoft#235)
    
    * Update psycopg to version 2.7.5 (microsoft#237)
    
    * Update to 2.7.5
    
    * Fixing flake error
    
    * Replace is with ==
    
    * Update PTVSD from 2.20 to 4.3.2 (microsoft#240)
    
    * updated ptvsd
    
    * Fixed flake8 errors
    
    * added azureAccountToken checks
    
    * removed dbname check in mysql driver
    
    * added pymysql back to requirements
    
    * Removed AAD from mysql + object explorer fix
    
    Co-authored-by: sasank-chaganty <[email protected]>
    Co-authored-by: Anup N. Kamath <[email protected]>
    Co-authored-by: swjain23 <[email protected]>
    Co-authored-by: Rich Smith <[email protected]>
    Co-authored-by: sergb213 <[email protected]>
    6 people authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    34aff37 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Configuration menu
    Copy the full SHA
    8025476 View commit details
    Browse the repository at this point in the history
  2. Revert "Fix query exception handling"

    This reverts commit 8025476.
    KevinMicrosoft committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    1c36c01 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Fix query exception handling (microsoft#244)

    * added new abstract driver property query_canceled_error to access psycopg2.extensions.QueryCanceledError
    * altered query exception handling to use abstracted driver properties
    * fixed batch execute function to avoid "cursor does not exist" operational error
    KevinMicrosoft authored Jun 29, 2020
    Configuration menu
    Copy the full SHA
    0db70a9 View commit details
    Browse the repository at this point in the history
  2. Fixed pg table completion (microsoft#245)

    * fixed metadata executor to call ServerConnection function get_cursor()
    * passed logger into CompletionRefresher
    KevinMicrosoft authored Jun 29, 2020
    Configuration menu
    Copy the full SHA
    e80c34c View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Rename pgtoolsservice to ossdbtoolsservice (microsoft#247)

    * Rename pgtoolsservice to ossdbtoolsservice
    
    * Rename tools service in README
    KevinMicrosoft authored Jul 1, 2020
    Configuration menu
    Copy the full SHA
    14f2ec4 View commit details
    Browse the repository at this point in the history
  2. Fixed pg handle definition request (microsoft#246)

    * edited Scripter constructor to accept a ServerConnection and then grab the correct Server
    * changed scripting service to pass in a connection and removed its connection to server translation
    KevinMicrosoft authored Jul 1, 2020
    Configuration menu
    Copy the full SHA
    1ddc624 View commit details
    Browse the repository at this point in the history
  3. Fix pg edit data (microsoft#248)

    * switched driver function from get_cursor to cursor to match previous usages
    * added a connection property to pg and mysql extensions
    * edited data_editor_session to properly use ServerConnection objects
    KevinMicrosoft authored Jul 1, 2020
    Configuration menu
    Copy the full SHA
    5148a28 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Add mysql literals (keywords + functions) completion (microsoft#249)

    * switched metadata_executor back to cursor()
    
    * initial mysql keyword completer
    
    * Improved mysql literals
    
    * fix server versionc checks in metadata executor
    
    * Fixed imports ordering
    
    * Removed pg table filtering from mysqlcomplter
    
    * Removed search_path
    
    * temp mysqlsmo search_path and schemas
    
    * Added separate lightweight metadata
    
    * removed unused variables from mysqlligthweight
    
    * Removed unsupported methods from mysqlcompleter
    
    * Empty mysql completer extend functions
    
    * Add literals only get_function_matches
    
    * new common completer class
    KevinMicrosoft authored Jul 13, 2020
    Configuration menu
    Copy the full SHA
    cc6f88a View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Fixed tests broken from the addition of MySQL support (microsoft#255)

    * Fix attribute errors
    
    * 2 errors and 13 failures
    
    * Altered language service to use config
    
    * add multilthreading back to metadata service
    
    * 0 errors and 0 fails
    
    * Added notices handling to batch.py
    
    * Fixed language service and operations queue tests
    
    * Added default db handling to mysql
    Added new MSSQL URI set to language service
    
    * Forgot to add back a line
    
    * Renamed mock conns and minimized MockServerConn
    
    * Alphabetized import statements
    KevinMicrosoft authored Jul 29, 2020
    Configuration menu
    Copy the full SHA
    8f0fc40 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Adding AAD auth (microsoft#261)

    Adding azureaccounttoken as a connection property
    Setting the token as the password if a token is provided. This way if AAD auth is used, AAD token replaces standard password when authenticating
    anjalia authored Jul 30, 2020
    Configuration menu
    Copy the full SHA
    2fe6e47 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Switched from multi-provider valid uri set to single-provider (micros…

    …oft#262)
    
    * Language Service changed to store uri's only for its provider
    
    * Added mysql flavor changes tests
    KevinMicrosoft authored Jul 31, 2020
    Configuration menu
    Copy the full SHA
    6a3b359 View commit details
    Browse the repository at this point in the history
  2. New mysql completer and completion refresher tests (microsoft#263)

    * Added MySQL Completer tests and added multi provider tests to completion refresher
    
    * Added keyword casing tests to both PG and MySQL completer
    
    * Created new MockMySQLServerConnection, MockPyMySQLConnection, and mysql MockCursor
    KevinMicrosoft authored Jul 31, 2020
    Configuration menu
    Copy the full SHA
    cff808c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2020

  1. Configuration menu
    Copy the full SHA
    29fead7 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Configuration menu
    Copy the full SHA
    cbb84a3 View commit details
    Browse the repository at this point in the history
Loading