Skip to content
This repository was archived by the owner on Sep 12, 2023. It is now read-only.

Commit cc29a51

Browse files
vanGalileamadsroskarkhushal87santhoshvaivishalnarkhede
authored
Next Release (GetStream#1323)
* fix: set border radius to 16 for giphy selector * style: move borderBottomRightRadius before borderRadius * feat: add theming support for the chevron icon in scroll to bottom button * fix: broken link in the push doc * fix: github workflow did not support android compileSdk 31 (GetStream#1318) * fix: android sample app build broken on compileSdk 31 * chore: temporarily enable sample app distribution test for this branch * chore: temporarily disable ios sample app build * Revert "chore: temporarily enable sample app distribution test for this branch" This reverts commit 371f0b1. * Revert "chore: temporarily disable ios sample app build" This reverts commit e07b851. * chore: apply dependabot version changes (GetStream#1308) * fix: manually update iOS version to 93 * [fastlane][ios] Bump version [skip ci] * [fastlane][ios] Bump version [skip ci] * fix: broken reanimated 2 links also added proguard rules * chore: update bug report and create feature request template issues (GetStream#1321) * chore: update bug report and create feature request template issues * Update bug_report.md * [fastlane][ios] Bump version [skip ci] * [fastlane][ios] Bump version [skip ci] Co-authored-by: Mads Røskar <[email protected]> Co-authored-by: Khushal Agarwal <[email protected]> Co-authored-by: Santhosh Vaiyapuri <[email protected]> Co-authored-by: Vishal Narkhede <[email protected]> Co-authored-by: Santhosh Vaiyapuri <[email protected]> Co-authored-by: Mads Røskar <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]>
1 parent 5654c39 commit cc29a51

File tree

18 files changed

+124
-45
lines changed

18 files changed

+124
-45
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,8 @@
22
name: Bug report
33
about: Create a report to help us improve
44
title: ''
5-
labels: ''
6-
assignees:
7-
- vishalnarkhede
8-
- madsroskar
5+
labels: 'Needs Triaging'
6+
assignees: ''
97

108
---
119

@@ -14,7 +12,10 @@ PLEASE READ THIS BEFORE PROCEEDING:
1412
1513
Did you check docs? - https://getstream.io/chat/docs/sdk/reactnative
1614
17-
If you are looking for an answer to "how to implement/do ... using xx component?" question, please check the Guides section of the docs. If you can't find an answer there, please leave a comment here - https://github.com/GetStream/stream-chat-react-native/issues/184 and I will try to add/include a sample code or example as soon as possible to Guides section of docs. This way it can help the other devs who are looking for same answer. Also if you have some feedback regarding docs, please don't hesitate to comment there.
15+
If you are looking for an answer to "how to implement/do ... using xx component?" question, please check the Guides section of the docs.
16+
If you can't find an answer there, please create an issue, and we will try to add/include a sample code or example to the Guides section of docs.
17+
This way it can help the other devs who are looking for the same answer.
18+
Also if you have some feedback regarding docs, please don't hesitate to comment there.
1819
1920
Your co-operation is really-really appreciated in this manner. Thanks and happy coding :)
2021
-->
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
---
2+
name: Feature request
3+
about: Describe a new feature
4+
title: ''
5+
labels: 'Feature Request'
6+
assignees: ''
7+
8+
---
9+
10+
<!--
11+
PLEASE READ THIS BEFORE PROCEEDING:
12+
13+
Did you check docs? - https://getstream.io/chat/docs/sdk/reactnative
14+
15+
If you are looking for an answer to "how to implement/do ... using xx component?" question, please check the Guides section of the docs.
16+
If you can't find an answer there, please create an issue, and we will try to add/include a sample code or example to the Guides section of docs.
17+
This way it can help the other devs who are looking for same answer.
18+
Also if you have some feedback regarding docs, please don't hesitate to comment there.
19+
20+
Your co-operation is really-really appreciated in this manner. Thanks and happy coding :)
21+
-->
22+
23+
24+
**Motivation**
25+
A clear and concise description of what the problem/opportunity is. Ex. I'm always frustrated when [...]
26+
27+
**Proposed solution**
28+
A clear and concise description of what you want to happen.
29+
30+
**Acceptance Criteria**
31+
A set of predefined requirements that must be met to mark a user story complete.

.github/workflows/sample-distribution.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,11 @@ jobs:
4949
runs-on: ubuntu-latest
5050
steps:
5151
- uses: actions/checkout@v2
52-
- uses: actions/setup-java@v1
52+
- uses: actions/setup-java@v3
5353
with:
54-
java-version: 1.8
54+
distribution: 'zulu'
55+
java-version: '11'
56+
check-latest: true
5557
- name: RN setup
5658
uses: nick-invision/retry@v2
5759
with:

docusaurus/docs/reactnative/basics/troubleshooting.mdx

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,17 +327,33 @@ The solution may require using a different touchable from React Native Gesture H
327327
328328
## Reanimated 2
329329
330-
We rely on Reanimated 2 heavily for gesture based interactions and animations. It is vital you follow the [Reanimated 2 installation instructions](https://docs.swmansion.com/react-native-reanimated/docs/installation/) for the library to work properly.
330+
We rely on Reanimated 2 heavily for gesture based interactions and animations. It is vital you follow the [Reanimated 2 installation instructions](https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation/) for the library to work properly.
331331
332332
### Failed to create a worklet
333333
334-
If you are encountering errors related to `Reanimated 2 failed to create a worklet` you must likely forgot to add the `react-native-reanimated/plugin` to your `babel.config.js` file.
334+
If you are encountering errors related to `Reanimated 2 failed to create a worklet` you must likely forgot to add the `react-native-reanimated/plugin` to your [project's babel config file](https://babeljs.io/docs/en/config-files). Below is an example of adding Reanimated's babel plugin to `babel.config.js`:
335+
336+
```js
337+
module.exports = {
338+
...
339+
plugins: [
340+
...
341+
'react-native-reanimated/plugin',
342+
],
343+
};
344+
```
345+
346+
:::caution
347+
348+
Reanimated plugin has to be listed last.
349+
350+
:::
335351
336352
### Blank screen on Android
337353
338-
If you are encountering errors on Android and the screen is blank it is likely you forgot to finish the [Reanimated 2 Android setup](https://docs.swmansion.com/react-native-reanimated/docs/installation/#android).
354+
If you are encountering errors on Android and the screen is blank it is likely you forgot to finish the [Reanimated 2 Android setup](https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation/#android).
339355
340-
Ensure Hermes is enabled in `android/app/build.gradle`
356+
Ensure Hermes is enabled in `android/app/build.gradle`:
341357
342358
```java
343359
project.ext.react = [
@@ -368,6 +384,15 @@ private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
368384
...
369385
```
370386
387+
### Android release bundle is crashing
388+
389+
This is likely due to proguard removing reanimated 2 related classes. If you're using Proguard, make sure to add the rules below:
390+
391+
```
392+
-keep class com.swmansion.reanimated.** { *; }
393+
-keep class com.facebook.react.turbomodule.** { *; }
394+
```
395+
371396
## Project won't build on a MacBook with Apple M1
372397
373398
On newer MacBooks with the Apple M1 SoC, there are a few required steps that need to be followed for an app to build. The user [aiba](https://github.com/aiba) has written [a guide](https://github.com/aiba/react-native-m1) to make the necessary changes to your project.

docusaurus/docs/reactnative/guides/push_notifications_v2.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ To listen to notifications on the background, you can use the [`setBackgroundMes
228228
229229
:::caution
230230
231-
This handler works only on Android. For this handler to work on iOS, the payload must be [customised](#make-ios-payload-to-be-data-only) `data` only.
231+
This handler works only on Android. For this handler to work on iOS, the payload must be [customised `data` only](#make-ios-payload-data-only).
232232
233233
:::
234234

examples/SampleApp/ios/SampleApp.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@
514514
CLANG_ENABLE_MODULES = YES;
515515
CODE_SIGN_ENTITLEMENTS = SampleApp/SampleAppDebug.entitlements;
516516
CODE_SIGN_IDENTITY = "iPhone Developer";
517-
CURRENT_PROJECT_VERSION = 92;
517+
CURRENT_PROJECT_VERSION = 97;
518518
DEVELOPMENT_TEAM = EHV7XZLAHA;
519519
ENABLE_BITCODE = NO;
520520
INFOPLIST_FILE = SampleApp/Info.plist;
@@ -545,7 +545,7 @@
545545
CODE_SIGN_ENTITLEMENTS = SampleApp/SampleAppRelease.entitlements;
546546
CODE_SIGN_IDENTITY = "iPhone Distribution";
547547
CODE_SIGN_STYLE = Manual;
548-
CURRENT_PROJECT_VERSION = 92;
548+
CURRENT_PROJECT_VERSION = 97;
549549
DEVELOPMENT_TEAM = EHV7XZLAHA;
550550
INFOPLIST_FILE = SampleApp/Info.plist;
551551
LD_RUNPATH_SEARCH_PATHS = (

examples/SampleApp/ios/SampleApp/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>1.3.1</string>
20+
<string>1.4.0</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleVersion</key>
24-
<string>92</string>
24+
<string>97</string>
2525
<key>LSRequiresIPhoneOS</key>
2626
<true />
2727
<key>NSAppTransportSecurity</key>

examples/SampleApp/ios/SampleAppTests/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
<key>CFBundlePackageType</key>
1616
<string>BNDL</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>1.3.1</string>
18+
<string>1.4.0</string>
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>
22-
<string>92</string>
22+
<string>97</string>
2323
</dict>
2424
</plist>

examples/SampleApp/yarn.lock

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5730,9 +5730,9 @@ minimatch@^3.0.2, minimatch@^3.0.4:
57305730
brace-expansion "^1.1.7"
57315731

57325732
minimist@^1.1.1, minimist@^1.2.0, minimist@^1.2.5:
5733-
version "1.2.5"
5734-
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.5.tgz#67d66014b66a6a8aaa0c083c5fd58df4e4e97602"
5735-
integrity sha512-FM9nNUYrRBAELZQT3xeZQ7fmMOBg6nWNmJKTcgsJeaLstP/UODVpGsr5OhXhhXg6f+qtJ8uiZ+PUxkDWcgIXLw==
5733+
version "1.2.6"
5734+
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44"
5735+
integrity sha512-Jsjnk4bw3YJqYzbdyBiNsPWHPfO++UGG749Cxs6peCu5Xg4nrena6OVxOYxrQTqww0Jmwt+Ref8rggumkTLz9Q==
57365736

57375737
mixin-deep@^1.2.0:
57385738
version "1.3.2"
@@ -7412,12 +7412,27 @@ [email protected]:
74127412
stream-chat "6.2.0"
74137413

74147414
"stream-chat-react-native-core@link:../../package":
7415-
version "0.0.0"
7416-
uid ""
7415+
version "4.3.1"
7416+
dependencies:
7417+
"@babel/runtime" "^7.12.5"
7418+
"@gorhom/bottom-sheet" "4.1.5"
7419+
dayjs "1.10.5"
7420+
file-loader "6.2.0"
7421+
i18next "20.2.4"
7422+
lodash-es "4.17.21"
7423+
metro-react-native-babel-preset "0.66.2"
7424+
mime-types "^2.1.34"
7425+
path "0.12.7"
7426+
react-art "^17.0.2"
7427+
react-native-markdown-package "1.8.1"
7428+
react-native-url-polyfill "^1.3.0"
7429+
stream-chat "6.2.0"
74177430

74187431
"stream-chat-react-native@link:../../package/native-package":
7419-
version "0.0.0"
7420-
uid ""
7432+
version "4.3.1"
7433+
dependencies:
7434+
es6-symbol "^3.1.3"
7435+
stream-chat-react-native-core "4.3.1"
74217436

74227437
74237438
version "6.2.0"

examples/TypeScriptMessaging/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ GEM
4545
public_suffix (~> 4.0)
4646
typhoeus (~> 1.0)
4747
cocoapods-deintegrate (1.0.5)
48-
cocoapods-downloader (1.5.1)
48+
cocoapods-downloader (1.6.3)
4949
cocoapods-plugins (1.0.0)
5050
nap
5151
cocoapods-search (1.0.1)

0 commit comments

Comments
 (0)