-
Notifications
You must be signed in to change notification settings - Fork 109
chore: Upgrade httpx to ^0.28.0 and respx to ^0.22.0 for Python 3.8+ #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
afd76bb to
c7f8f55
Compare
|
Resolved the
|
- Upgraded respx from 0.21.1 to 0.22.0 to resolve compatibility issues with httpx 0.28.0 - All tests now pass with the updated httpx version
48860ce to
3f78a6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
31-34: Respx matrix is logically correct; minor formatting inconsistency.The respx version matrix (
^0.21.1for Python ≤3.7,^0.22.0for Python ^3.8) properly aligns with the httpx 0.28.0 compatibility requirement mentioned in the PR.However, there's a minor formatting inconsistency: the respx entries use
{version = ...while the httpx matrix above uses{ version = ...(note the space after the opening brace).Apply this diff to align spacing with the httpx matrix:
respx = [ - {version = "^0.21.1", python = "<=3.7" }, - {version = "^0.22.0", python = "^3.8" }, + { version = "^0.21.1", python = "<=3.7" }, + { version = "^0.22.0", python = "^3.8" }, ]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(2 hunks)
🔇 Additional comments (1)
pyproject.toml (1)
13-16: httpx version matrix update looks good.The constraint maintains backward compatibility for Python 3.7 (keeping
^0.24.0) while bumping to^0.28.0for Python 3.8+, aligning with the respx compatibility requirements noted in the PR. The matrix structure is consistent with how other conditional dependencies are specified.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 91.53% 91.29% -0.24%
==========================================
Files 92 92
Lines 8646 8619 -27
==========================================
- Hits 7914 7869 -45
- Misses 732 750 +18 see 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
cf0a56e to
cf584ce
Compare
|
Hi @chyroc , sorry about that, I was just able to have a python3.7 environment to run the unit tests. Now I fixed this, please take another look~ |
This PR completes the
httpxbump to version ^0.28.0 by updating the lock file, which was missing from a previous attempt by #320 .Changes
httpxversion:^0.27.0→^0.28.0inpyproject.tomlrespxversion:^0.21.1→^0.22.0Context
A previous PR (#320 ) updated the version constraint but didn't regenerate the lock file, which caused CI failures in practice. This PR addresses that by running the lock file update.
Summary by CodeRabbit