Bug#20035071: Out of range error in subselect lead to assertion failed

There is a missing error check during preparation of this query,
so that we reach the regular function return in
st_select_lex::prepare(). However, there has been an error when
evaluating the LIKE predicate, which has gone unnoticed.

The fix applies to Item_func_like::fix_fields(), check if the call
to val_str() returns an error. However, the real fix should be to
check for error in Item_real_func::val_str(). But since this function
has no easily accessible THD reference, it's better to do it this way.

Author: roylyseng

mysql-test/r/func_like.result

@@ -266,3 +266,8 @@ SELECT * FROM t2 WHERE y LIKE 'abc%%' ESCAPE (SELECT 'c' FROM t1) ORDER BY y;
 x	y
 2	ab%cde
 DROP TABLE t1, t2;
+# Bug#20035071: Out of range error in subselect lead to assertion failed
+CREATE TABLE t1(a INTEGER) engine=innodb;
+SELECT 1 FROM t1 HAVING (SELECT 1 FROM t1) LIKE EXP(NOW());
+ERROR 22003: DOUBLE value is out of range in 'exp(now())'
+DROP TABLE t1;

mysql-test/t/func_like.test

@@ -203,3 +203,10 @@ eval EXPLAIN $query;
 eval $query;
 
 DROP TABLE t1, t2;
+
+--echo # Bug#20035071: Out of range error in subselect lead to assertion failed
+
+CREATE TABLE t1(a INTEGER) engine=innodb;
+--error ER_DATA_OUT_OF_RANGE
+SELECT 1 FROM t1 HAVING (SELECT 1 FROM t1) LIKE EXP(NOW());
+DROP TABLE t1;

sql/item_cmpfunc.cc

@@ -6047,6 +6047,8 @@ bool Item_func_like::fix_fields(THD *thd, Item **ref)
        !(specialflag & SPECIAL_NO_NEW_FUNC))
     {
       String* res2 = args[1]->val_str(&cmp.value2);
+      if (thd->is_error())
+        return true;
       if (!res2)
         return false;				// Null argument