Bug#18064775 Assertion failed: fields.elements == values.elements

Bug#11745889 Traditional: INSERT accepts invalid date from default value

A recent bugfix (16820562) gave column count zero a special meaning,
but failed to give an error for the case of zero column names but more
than zero column values.

The fix is to check explicitly for this case. The interface for
check_insert_fields() has been extended with a bool value_count_known,
to make it easy to remove it when the "known" property is no longer
needed (all values are actually "known", but the code path is clumsy).

The bugfix also re-introduced bug 11745889, which was fixed by bug
16078943, alas it did not contain a test for this particular case.

The fix for this bug is to treat INSERT statements with no column names
and no column values specified as if a partial (but empty) column list
has been specified. This way, the write_set for the table is not
populated and the columns will be picked for validation of default
values.

Author: roylyseng

mysql-test/r/insert.result

@@ -596,3 +596,26 @@ Warning	1287	'@@max_insert_delayed_threads' is deprecated and will be removed in
 SET GLOBAL max_delayed_threads = DEFAULT;
 Warnings:
 Warning	1287	'@@max_delayed_threads' is deprecated and will be removed in a future release.
+#
+# Bug#18064775 Assertion failed: fields.elements == values.elements
+#
+CREATE TABLE t1(a INTEGER);
+INSERT INTO t1(a) values();
+ERROR 21S01: Column count doesn't match value count at row 1
+DROP TABLE t1;
+#
+# Bug#11745889 Traditional: INSERT accepts invalid date from default val
+#
+SET sql_mode='';
+CREATE TABLE default_date(a DATE NOT NULL DEFAULT '0000-00-00');
+INSERT INTO default_date VALUES();
+SET sql_mode='traditional';
+INSERT INTO default_date VALUES();
+ERROR 22007: Incorrect date value: '0000-00-00' for column 'a' at row 1
+INSERT INTO default_date VALUES('0000-00-00');
+ERROR 22007: Incorrect date value: '0000-00-00' for column 'a' at row 1
+SELECT * FROM default_date;
+a
+0000-00-00
+DROP TABLE default_date;
+SET sql_mode=default;

mysql-test/t/insert.test

@@ -431,3 +431,36 @@ SET GLOBAL delayed_insert_timeout = DEFAULT;
 SET GLOBAL delayed_queue_size = DEFAULT;
 SET GLOBAL max_insert_delayed_threads = DEFAULT;
 SET GLOBAL max_delayed_threads = DEFAULT;
+
+--echo #
+--echo # Bug#18064775 Assertion failed: fields.elements == values.elements
+--echo #
+
+CREATE TABLE t1(a INTEGER);
+--error ER_WRONG_VALUE_COUNT_ON_ROW
+INSERT INTO t1(a) values();
+DROP TABLE t1;
+
+--echo #
+--echo # Bug#11745889 Traditional: INSERT accepts invalid date from default val
+--echo #
+
+SET sql_mode='';
+
+CREATE TABLE default_date(a DATE NOT NULL DEFAULT '0000-00-00');
+
+INSERT INTO default_date VALUES();
+
+SET sql_mode='traditional';
+
+--error ER_TRUNCATED_WRONG_VALUE
+INSERT INTO default_date VALUES();
+
+--error ER_TRUNCATED_WRONG_VALUE
+INSERT INTO default_date VALUES('0000-00-00');
+
+SELECT * FROM default_date;
+
+DROP TABLE default_date;
+
+SET sql_mode=default;

sql/sql_insert.cc

@@ -96,15 +96,23 @@ static bool check_view_single_update(List<Item> &fields, TABLE_LIST *view,
   @param table_list   The table for insert.
   @param fields       The insert fields.
   @param value_count  Number of values supplied
-                      = 0: INSERT ... SELECT, delay field count check
+  @param value_count_known if false, delay field count check
+                      @todo: Eliminate this when preparation is properly phased
   @param check_unique If duplicate values should be rejected.
   @param[out] insert_table_ref resolved reference to base table
 
   @return false if success, true if error
+
+  @todo check_insert_fields() should be refactored as follows:
+        - Remove the argument value_count_known and all predicates involving it.
+        - Rearrange the call to check_insert_fields() from
+          mysql_prepare_insert() so that the value_count is known also when
+          processing a prepared statement.
 */
 
 static bool check_insert_fields(THD *thd, TABLE_LIST *table_list,
                                 List<Item> &fields, uint value_count,
+                                bool value_count_known,
                                 bool check_unique,
                                 TABLE_LIST **insert_table_ref)
 {
@@ -114,15 +122,18 @@ static bool check_insert_fields(THD *thd, TABLE_LIST *table_list,
 
   DBUG_ASSERT(table_list->updatable);
 
-  if (fields.elements == 0)
+  if (fields.elements == 0 && value_count_known && value_count > 0)
   {
-    // No field list supplied, use field list of table being updated.
-
+    /*
+      No field list supplied, but a value list has been supplied.
+      Use field list of table being updated.
+    */
     DBUG_ASSERT(table);    // This branch is not reached with a view:
 
     *insert_table_ref= table_list;
 
-    if (value_count > 0 && value_count != table->s->fields)
+    // Values for all fields in table are needed
+    if (value_count != table->s->fields)
     {
       my_error(ER_WRONG_VALUE_COUNT_ON_ROW, MYF(0), 1L);
       return true;
@@ -147,7 +158,7 @@ static bool check_insert_fields(THD *thd, TABLE_LIST *table_list,
     Name_resolution_context_state ctx_state;
     int res;
 
-    if (value_count > 0 && fields.elements != value_count)
+    if (value_count_known && fields.elements != value_count)
     {
       my_error(ER_WRONG_VALUE_COUNT_ON_ROW, MYF(0), 1L);
       return true;
@@ -1173,8 +1184,10 @@ bool mysql_prepare_insert(THD *thd, TABLE_LIST *table_list,
     table_list->next_local= NULL;
     context->resolve_in_table_list_only(table_list);
 
-    res= check_insert_fields(thd, context->table_list, fields, values->elements,
-                             !insert_into_view, insert_table_ref);
+    if (!res)
+      res= check_insert_fields(thd, context->table_list, fields,
+                               values->elements, true,
+                               !insert_into_view, insert_table_ref);
     table_map map= 0;
     if (!res)
       map= (*insert_table_ref)->table->map;
@@ -1218,7 +1231,14 @@ bool mysql_prepare_insert(THD *thd, TABLE_LIST *table_list,
     thd->dup_field= NULL;
     context->resolve_in_table_list_only(table_list);
 
-    res= check_insert_fields(thd, context->table_list, fields, 0,
+    /*
+      When processing a prepared INSERT ... SELECT statement,
+      mysql_prepare_insert() is called from
+      mysql_insert_select_prepare_tester(), when the values list (aka the
+      SELECT list from the SELECT) is not resolved yet, so pass "false"
+      for value_count_known.
+    */
+    res= check_insert_fields(thd, context->table_list, fields, 0, false,
                              !insert_into_view, insert_table_ref);
     table_map map= 0;
     if (!res)
@@ -1811,8 +1831,8 @@ select_insert::prepare(List<Item> &values, SELECT_LEX_UNIT *u)
 
   /* Errors during check_insert_fields() should not be ignored. */
   lex->current_select()->no_error= FALSE;
-  res= check_insert_fields(thd, table_list, *fields, values.elements,
-                            !insert_into_view, &insert_table_ref);
+  res= check_insert_fields(thd, table_list, *fields, values.elements, true,
+                           !insert_into_view, &insert_table_ref);
   if (!res)
     res= setup_fields(thd, Ref_ptr_array(), values, MARK_COLUMNS_READ, 0, 0);