Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: danieljfarrell/pvtrace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: danieljfarrell/pvtrace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/time-resolved
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 3, 2020

  1. Add radiative lifetime

    Luminophores can be created with an optional `lifetime` keyword.
    
    Ray now includes a `duration` parameter.
    
    Ray.propagate has been updated to calculate the propagation time
    over the distance, this updates the `duration` attribute.
    
    When a luminophore emits, a single exponential distribution is
    sampled using the `lifetime` as the decay constant to get a
    time delay for fluorescence.
    
    Problems
    --------
    
    1. Calculating the propagation distance requires that the distance
       units are known. Up until now, pvtrace has been agnostic to
       units of the length dimension. In the commit, we assume units
       are centimetres. We will return to this issue.
    
    2. The non-radiative time is not included. Due to the way pvtrace
       has been coded there is not an easy way to include
       non-radiative absorption lifetime. We will need to add an
       Component.absorb(ray) method which uses the non-radiative
       lifetime parameter.
    danieljfarrell committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    df68e56 View commit details
    Browse the repository at this point in the history
  2. Refactor and include non-rad lifetime

    Slight refactor. Renamed lifetimes to `tau_rad` and `tau_nr`.
    
    User must specify either a quantum yield or both tau_rad and
    tau_nr. The latter will enable time-resolved ray-tracing mode.
    
    Add new event NONRADIATIVE and updated the ray tracing algorithm.
    danieljfarrell committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    2381dd2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b66dc4c View commit details
    Browse the repository at this point in the history
Loading