Storage/STG91 Renamed PublicAudience to DefaultAudience (Azure#5022)

* Change Audience

* change PublicAudience to DefaultAudience

Author: microzchang

sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_options.hpp

@@ -46,7 +46,7 @@ namespace Azure { namespace Storage { namespace Blobs {
        * @brief Default Audience. Use to acquire a token for authorizing requests to any Azure
        * Storage account.
        */
-      AZ_STORAGE_BLOBS_DLLEXPORT const static BlobAudience PublicAudience;
+      AZ_STORAGE_BLOBS_DLLEXPORT const static BlobAudience DefaultAudience;
     };
   } // namespace Models
 
@@ -198,7 +198,7 @@ namespace Azure { namespace Storage { namespace Blobs {
 
     /**
      * The Audience to use for authentication with Azure Active Directory (AAD).
-     * #Azure::Storage::Blobs::Models::BlobAudience::PublicAudience will be assumed if Audience is
+     * #Azure::Storage::Blobs::Models::BlobAudience::DefaultAudience will be assumed if Audience is
      * not set.
      */
     Azure::Nullable<Models::BlobAudience> Audience;

sdk/storage/azure-storage-blobs/src/blob_options.cpp

@@ -6,7 +6,7 @@
 namespace Azure { namespace Storage { namespace Blobs {
 
   namespace Models {
-    const BlobAudience BlobAudience::PublicAudience(_internal::StoragePublicAudience);
+    const BlobAudience BlobAudience::DefaultAudience(_internal::StorageDefaultAudience);
   } // namespace Models
 
   BlobQueryInputTextOptions BlobQueryInputTextOptions::CreateCsvTextOptions(

sdk/storage/azure-storage-blobs/test/ut/block_blob_client_test.cpp

@@ -2035,13 +2035,13 @@ namespace Azure { namespace Storage { namespace Test {
         InitStorageClientOptions<Azure::Identity::ClientSecretCredentialOptions>());
     auto clientOptions = InitStorageClientOptions<Blobs::BlobClientOptions>();
 
-    // default audience
+    // audience by default
     auto blockBlobClient
         = Blobs::BlockBlobClient(m_blockBlobClient->GetUrl(), credential, clientOptions);
     EXPECT_NO_THROW(blockBlobClient.GetProperties());
 
-    // public audience
-    clientOptions.Audience = Blobs::Models::BlobAudience::PublicAudience;
+    // default audience
+    clientOptions.Audience = Blobs::Models::BlobAudience::DefaultAudience;
     blockBlobClient
         = Blobs::BlockBlobClient(m_blockBlobClient->GetUrl(), credential, clientOptions);
     EXPECT_NO_THROW(blockBlobClient.GetProperties());

sdk/storage/azure-storage-common/inc/azure/storage/common/internal/constants.hpp

@@ -11,7 +11,7 @@ namespace Azure { namespace Storage { namespace _internal {
   constexpr static const char* HttpQuerySnapshot = "snapshot";
   constexpr static const char* HttpQueryVersionId = "versionid";
   constexpr static const char* StorageScope = "https://storage.azure.com/.default";
-  constexpr static const char* StoragePublicAudience = "https://storage.azure.com";
+  constexpr static const char* StorageDefaultAudience = "https://storage.azure.com";
   constexpr static const char* HttpHeaderDate = "date";
   constexpr static const char* HttpHeaderXMsVersion = "x-ms-version";
   constexpr static const char* HttpHeaderRequestId = "x-ms-request-id";

sdk/storage/azure-storage-files-datalake/inc/azure/storage/files/datalake/datalake_options.hpp

@@ -103,7 +103,7 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake {
        * @brief Default Audience. Use to acquire a token for authorizing requests to any Azure
        * Storage account.
        */
-      AZ_STORAGE_FILES_DATALAKE_DLLEXPORT const static DataLakeAudience PublicAudience;
+      AZ_STORAGE_FILES_DATALAKE_DLLEXPORT const static DataLakeAudience DefaultAudience;
     };
   } // namespace Models
 
@@ -173,8 +173,8 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake {
 
     /**
      * The Audience to use for authentication with Azure Active Directory (AAD).
-     * #Azure::Storage::Files::DataLake::Models::DataLakeAudience::PublicAudience will be assumed if
-     * Audience is not set.
+     * #Azure::Storage::Files::DataLake::Models::DataLakeAudience::DefaultAudience will be assumed
+     * if Audience is not set.
      */
     Azure::Nullable<Models::DataLakeAudience> Audience;
   };

sdk/storage/azure-storage-files-datalake/src/datalake_options.cpp

@@ -5,6 +5,6 @@
 
 namespace Azure { namespace Storage { namespace Files { namespace DataLake { namespace Models {
 
-  const DataLakeAudience DataLakeAudience::PublicAudience(_internal::StoragePublicAudience);
+  const DataLakeAudience DataLakeAudience::DefaultAudience(_internal::StorageDefaultAudience);
 
 }}}}} // namespace Azure::Storage::Files::DataLake::Models

sdk/storage/azure-storage-files-datalake/test/ut/datalake_path_client_test.cpp

@@ -489,13 +489,13 @@ namespace Azure { namespace Storage { namespace Test {
         InitStorageClientOptions<Azure::Identity::ClientSecretCredentialOptions>());
     auto clientOptions = InitStorageClientOptions<Files::DataLake::DataLakeClientOptions>();
 
-    // default audience
+    // audience by default
     auto pathClient
         = Files::DataLake::DataLakePathClient(m_pathClient->GetUrl(), credential, clientOptions);
     EXPECT_NO_THROW(pathClient.GetProperties());
 
-    // public audience
-    clientOptions.Audience = Files::DataLake::Models::DataLakeAudience::PublicAudience;
+    // default audience
+    clientOptions.Audience = Files::DataLake::Models::DataLakeAudience::DefaultAudience;
     pathClient
         = Files::DataLake::DataLakePathClient(m_pathClient->GetUrl(), credential, clientOptions);
     EXPECT_NO_THROW(pathClient.GetProperties());

sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_options.hpp

@@ -44,7 +44,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
        * @brief Default Audience. Use to acquire a token for authorizing requests to any Azure
        * Storage account.
        */
-      AZ_STORAGE_FILES_SHARES_DLLEXPORT const static ShareAudience PublicAudience;
+      AZ_STORAGE_FILES_SHARES_DLLEXPORT const static ShareAudience DefaultAudience;
     };
   } // namespace Models
 
@@ -80,7 +80,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
 
     /**
      * The Audience to use for authentication with Azure Active Directory (AAD).
-     * #Azure::Storage::Files::Shares::Models::ShareAudience::PublicAudience will be assumed if
+     * #Azure::Storage::Files::Shares::Models::ShareAudience::DefaultAudience will be assumed if
      * Audience is not set.
      */
     Azure::Nullable<Models::ShareAudience> Audience;

sdk/storage/azure-storage-files-shares/src/share_options.cpp

@@ -5,6 +5,6 @@
 
 namespace Azure { namespace Storage { namespace Files { namespace Shares { namespace Models {
 
-  const ShareAudience ShareAudience::PublicAudience(_internal::StoragePublicAudience);
+  const ShareAudience ShareAudience::DefaultAudience(_internal::StorageDefaultAudience);
 
 }}}}} // namespace Azure::Storage::Files::Shares::Models

sdk/storage/azure-storage-files-shares/test/ut/share_file_client_test.cpp

@@ -1702,13 +1702,13 @@ namespace Azure { namespace Storage { namespace Test {
     auto clientOptions = InitStorageClientOptions<Files::Shares::ShareClientOptions>();
     clientOptions.ShareTokenIntent = Files::Shares::Models::ShareTokenIntent::Backup;
 
-    // default audience
+    // audience by default
     auto fileClient
         = Files::Shares::ShareFileClient(m_fileClient->GetUrl(), credential, clientOptions);
     EXPECT_NO_THROW(fileClient.GetProperties());
 
-    // public audience
-    clientOptions.Audience = Files::Shares::Models::ShareAudience::PublicAudience;
+    // default audience
+    clientOptions.Audience = Files::Shares::Models::ShareAudience::DefaultAudience;
     fileClient = Files::Shares::ShareFileClient(m_fileClient->GetUrl(), credential, clientOptions);
     EXPECT_NO_THROW(fileClient.GetProperties());