converting document names to strings is a WTF factory

Author: danielsdeleo

lib/decider/document.rb

@@ -31,7 +31,7 @@ def custom_transforms(transforms_module)
     attr_writer :domain_tokens
 
     def initialize(name, raw_text)
-      @name, @raw = name.to_s, raw_text
+      @name, @raw = name, raw_text
       @domain_tokens, @additional_tokens, @finalized = [], [], false
     end
 

spec/unit/clustering/base_spec.rb

@@ -40,10 +40,10 @@
     @clusterer.push(:quick_brown, "the quick brown").push(:brown_fox, "brown fox jumped over")
     @clusterer.push(:lazy_dog, "lazy dog").push(:over_the, "over the quick brown dog")
     index_of = @clusterer.__send__(:token_indices)
-    @clusterer.vectors["quick_brown"].to_a.length.should == 8
+    @clusterer.vectors[:quick_brown].to_a.length.should == 8
     expected_vector = Array.new(8, 0)
     %w{over the quick brown dog}.each {|word| expected_vector[index_of[word]] = 1}
-    @clusterer.vectors["over_the"].to_a.should == expected_vector
+    @clusterer.vectors[:over_the].to_a.should == expected_vector
   end
 
 end

spec/unit/document_spec.rb

@@ -9,9 +9,8 @@
       Document.new(:simple_doc, "the original text").raw.should == "the original text"
     end
 
-    it "should have a name" do
-      Document.new(:simple_doc, "the original text").name.should == "simple_doc"
-      
+    it "should have a name and not convert it to a string" do
+      Document.new(:simple_doc, "the original text").name.should == :simple_doc
     end
 
   end