Remove some obsolete completers.

Author: jamesots

lib/src/connection_pool.dart

@@ -94,7 +94,10 @@ class ConnectionPool extends Object with _ConnectionHelpers implements Queriable
       _log.finest("Logged in on cnx#${cnx.number}");
       c.complete(cnx);
     } catch (e) {
-      _releaseReuseCompleteError(cnx, c, e);
+      if (!(e is MySqlException)) {
+        _removeConnection(cnx);
+      }
+      c.completeError(e);
     }
   }
 
@@ -175,7 +178,6 @@ class ConnectionPool extends Object with _ConnectionHelpers implements Queriable
     _log.info("Running query: ${sql}");
 
     var cnx = await _getConnection();
-    var c = new Completer<Results>();
     _log.fine("Got cnx#${cnx.number} for query");
     try {
       var results = await cnx.processHandler(new _QueryStreamHandler(sql));
@@ -269,15 +271,14 @@ class ConnectionPool extends Object with _ConnectionHelpers implements Queriable
 
     var cnx = await _getConnection();
     cnx.inTransaction = true;
-    var c = new Completer<Transaction>();
     var sql;
     if (consistent) {
       sql = "start transaction with consistent snapshot";
     } else {
       sql = "start transaction";
     }
     try {
-      var results = await cnx.processHandler(new _QueryStreamHandler(sql));
+      await cnx.processHandler(new _QueryStreamHandler(sql));
       _log.fine("Transaction started on cnx#${cnx.number}");
       return new _TransactionImpl._(cnx, this);
     } catch (e) {
@@ -327,14 +328,6 @@ class ConnectionPool extends Object with _ConnectionHelpers implements Queriable
 }
 
 abstract class _ConnectionHelpers {
-  _releaseReuseCompleteError(_Connection cnx, Completer c, dynamic e) {
-    if (e is MySqlException) {
-    } else {
-      _removeConnection(cnx);
-    }
-    c.completeError(e);
-  }
-
   _releaseReuseThrow(_Connection cnx, dynamic e) {
     if (!(e is MySqlException)) {
       _removeConnection(cnx);

lib/src/query.dart

@@ -26,11 +26,9 @@ class Query extends Object with _ConnectionHelpers {
       _inTransaction = true,
       _log = new Logger("Query");
 
-  Future<_Connection> _getConnection() {
+  Future<_Connection> _getConnection() async {
     if (_cnx != null) {
-      var c = new Completer<_Connection>();
-      c.complete(_cnx);
-      return c.future;
+      return _cnx;
     }
     return _pool._getConnection();
   }
@@ -104,7 +102,6 @@ class Query extends Object with _ConnectionHelpers {
   Future<Results> _execute(_PreparedQuery preparedQuery, List values,
       {bool retainConnection: false}) async {
     _log.finest("About to execute");
-    var c = new Completer<Results>();
     var handler = new _ExecuteQueryHandler(preparedQuery, _executed, values);
     preparedQuery.cnx.autoRelease = !retainConnection;
     try {
@@ -126,7 +123,6 @@ class Query extends Object with _ConnectionHelpers {
    */
   Future<List<Results>> executeMulti(List<List> parameters) async {
     var preparedQuery = await _prepare(true);
-    var c = new Completer<List<Results>>();
     _log.fine("Prepared query for multi execution. Number of values: ${parameters.length}");
     var resultList = new List<Results>();