Update databricks_metastore_data_access implementation to match databricks_storage_credential
#3431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3431 +/- ##
==========================================
+ Coverage 82.34% 82.48% +0.14%
==========================================
Files 190 191 +1
Lines 19323 19331 +8
==========================================
+ Hits 15911 15946 +35
+ Misses 2480 2456 -24
+ Partials 932 929 -3
|
mgyucht
reviewed
Apr 5, 2024
Contributor
mgyucht
left a comment
mgyucht
left a comment
There was a problem hiding this comment.
Should we do the same for the create method as well?
nkvuong
force-pushed
the
doc/metastore_dac
branch
from
ae2d595 to
f84e7aa
Compare
Contributor
Author
Refactoring Create is a bit tricky since we need |
alexott
reviewed
May 2, 2024
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
looks good, we just need to resolve conflicts
…tabricks_storage_credential`
Co-authored-by: Miles Yucht <[email protected]>
nkvuong
force-pushed
the
doc/metastore_dac
branch
from
741be55 to
009255b
Compare
alexott
reviewed
May 17, 2024
| // Rollback | ||
| rollback_err := acc.StorageCredentials.DeleteByMetastoreIdAndStorageCredentialName(ctx, metastoreId, dac.CredentialInfo.Name) | ||
| if rollback_err != nil { | ||
| return fmt.Errorf("failed to rollback: %v", rollback_err) |
Contributor
There was a problem hiding this comment.
Here we're hiding original error - should we put it here as well?
| // Rollback | ||
| rollback_err := w.StorageCredentials.DeleteByName(ctx, dac.Name) | ||
| if rollback_err != nil { | ||
| return fmt.Errorf("failed to rollback: %v", rollback_err) |
Contributor
|
@nkvuong do we still need it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
databricks_metastore_data_accessTests
make testrun locallydocs/folder