Removed misplaced context == EGL_NO_CONTEXT check in EAGL driver implementation.

Added explicit check/skip for case eglMakeCurrent(aDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT).
Fixed EGL_BAD_CONTEXT unit test when context is invalid and surfaces are valid.

Author: davidandreoletti

README-Dev

@@ -4,6 +4,7 @@ TODO Bug Priority List:
  - [self setupVideoFrameIntervalUpdates:0]; -> Sample1[85592:3303] *** -[__EAGLSurface setupVideoFrameIntervalUpdates:]: message sent to deallocated instance 0x8bab670 
  - Memory Leak: App starts with 8.5Mb without EGL. Running the demo consumes more 16Mb. When the demo stops, the memory consumption is higher than 8.5Mb
  - eglMakeCurrent(EGLDisplay dpy, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT) -> impact on ressource count 
+ -- are FB/CB etc clear ??? Should they ?
  - contentScaleFactor == 1 ? IN EAGL_eglCreateWindowSurface
 
 

src/EGL/drivers/eagl/egl_eagl.m

@@ -281,12 +281,7 @@ static EGLBoolean _checkSurfaceAttribMatchConfigAttrib(_EGLSurface* surf, _EGLCo
     EGLBoolean ret = EGL_FALSE;
 
     _EGL_CHECK_CONTEXTLOST(disp, EAGL_ctx, EGL_FALSE);
-    
-    if (!ctx) {
-        _eglError(EGL_BAD_CONTEXT, "eglMakeCurrent");
-        return EGL_FALSE;
-    }
-    
+        
     /* make new bindings */
     if (!_eglBindContext(ctx, dsurf, rsurf, &old_ctx, &old_dsurf, &old_rsurf)) {
         // TODO: Anything to do here ?

src/EGL/eglapi.c

@@ -483,7 +483,11 @@ eglMakeCurrent(EGLDisplay dpy, EGLSurface draw, EGLSurface read,
 
    if (!context && ctx != EGL_NO_CONTEXT)
       RETURN_EGL_ERROR(disp, EGL_BAD_CONTEXT, EGL_FALSE);
-   if (!draw_surf || !read_surf) {
+    if (draw_surf == EGL_NO_SURFACE && read_surf == EGL_NO_SURFACE &&
+        context == EGL_NO_CONTEXT) {
+        /* release the current context without assigning a new one */
+    }
+    else if (!draw_surf || !read_surf) {
       /* surfaces may be NULL if surfaceless */
       if (!disp->Extensions.KHR_surfaceless_context)
          RETURN_EGL_ERROR(disp, EGL_BAD_SURFACE, EGL_FALSE);

test/include/eglMakeCurrentTest.h

@@ -116,7 +116,7 @@ void eglMakeCurrent_6(TestPlatform* p) {
     //If ctx is not a valid context, an EGL_BAD_CONTEXT error is generated.
     EGLSurface surf;
     EGLDisplay dpy;
-    EGLContext ctx = NULL;
+    EGLContext ctx = 0x1;
     EGLint cattrib_list[5] = {EGL_COLOR_BUFFER_TYPE, EGL_RGB_BUFFER,
         EGL_RED_SIZE, 1,
         EGL_NONE};