Skip to content

Commit 21d51b3

Browse files
committed
Merge pull request mozilla#149 from mozilla/bug1257916
Fix how the message body string is built.
2 parents f85fc6b + 809a8e4 commit 21d51b3

File tree

1 file changed

+4
-16
lines changed
  • http/analysis-service/jobs

1 file changed

+4
-16
lines changed

http/analysis-service/jobs/run.sh

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,7 @@ if [ "$(jq -r '.num_workers|type' < $JOB_CONFIG)" == "number" ]; then # Spark cl
5353
if [ $EXIT_CODE -ne 0 ]; then
5454
# Error creating emr cluster. Notify owner.
5555
NOTIFY_SUBJECT="Scheduled Spark job '$JOB_NAME' encountered an error"
56-
NOTIFY_BODY=<<END
57-
Scheduled Telemetry Spark job '$JOB_NAME' exited with a code of $EXIT_CODE which
58-
indicates it probably encountered an error.
59-
END
56+
NOTIFY_BODY="Scheduled Telemetry Spark job '$JOB_NAME' exited with a code of $EXIT_CODE which indicates it probably encountered an error."
6057
fi
6158
else
6259
cd ~/telemetry-server
@@ -67,17 +64,11 @@ else
6764
# Job timed out. Notify owner.
6865
JOB_TIMEOUT=$(jq -r '.job_timeout_minutes' < "$JOB_CONFIG")
6966
NOTIFY_SUBJECT="Scheduled Telemetry job '$JOB_NAME' timed out"
70-
NOTIFY_BODY=<<END
71-
Scheduled Telemetry job '$JOB_NAME' was forcibly terminated after the configured
72-
timeout ($JOB_TIMEOUT minutes).
73-
END
67+
NOTIFY_BODY="Scheduled Telemetry job '$JOB_NAME' was forcibly terminated after the configured timeout ($JOB_TIMEOUT minutes)."
7468
elif [ $EXIT_CODE -ne 0 ]; then
7569
# Error running job. Notify owner.
7670
NOTIFY_SUBJECT="Scheduled Telemetry job '$JOB_NAME' encountered an error"
77-
NOTIFY_BODY=<<END
78-
Scheduled Telemetry job '$JOB_NAME' exited with code $EXIT_CODE which indicates
79-
it probably encountered an error.
80-
END
71+
NOTIFY_BODY="Scheduled Telemetry job '$JOB_NAME' exited with code $EXIT_CODE which indicates it probably encountered an error."
8172
fi
8273
fi
8374

@@ -89,11 +80,8 @@ if [ ! -z "$NOTIFY_SUBJECT" ]; then
8980
TO=$FROM
9081
NOTIFY_SUBJECT="$NOTIFY_SUBJECT (and had no owner)"
9182
fi
92-
NOTIFY_BODY=<<END
93-
$NOTIFY_BODY
83+
NOTIFY_BODY="$NOTIFY_BODY You can review the job's details at https://analysis.telemetry.mozilla.org"
9484

95-
You can review the job's details at http://analysis.telemetry.mozilla.org
96-
END
9785
aws ses send-email \
9886
--region $REGION \
9987
--from "$FROM" \

0 commit comments

Comments
 (0)