Merge pull request activeadmin#1782 from ptn/add_tests_for_has_many_js

Add tests for PR 1699

Author: pcreux

lib/active_admin/form_builder.rb

@@ -76,19 +76,7 @@ def has_many(association, options = {}, &block)
           form_buffers.last << template.content_tag(:h3, object.class.reflect_on_association(association).klass.model_name.human(:count => 1.1))
           inputs options, &form_block
 
-          # Capture the ADD JS
-          placeholder = "NEW_#{object.class.reflect_on_association(association).klass.model_name.human.upcase}_RECORD"
-          js = with_new_form_buffer do
-            inputs_for_nested_attributes  :for => [association, object.class.reflect_on_association(association).klass.new],
-                                          :class => "inputs has_many_fields",
-                                          :for_options => {
-                                            :child_index => placeholder
-                                          }, &form_block
-          end
-
-          js = template.escape_javascript(js)
-          js = template.link_to I18n.t('active_admin.has_many_new', :model => object.class.reflect_on_association(association).klass.model_name.human), "#", :onclick => "$(this).before('#{js}'.replace(/#{placeholder}/g, new Date().getTime())); return false;", :class => "button"
-
+          js = js_for_has_many(association, form_block, template)
           form_buffers.last << js.html_safe
         end
       end
@@ -181,5 +169,28 @@ def with_new_form_buffer
       return_value
     end
 
+    # Capture the ADD JS
+    def js_for_has_many(association, form_block, template)
+      association_reflection = object.class.reflect_on_association(association)
+      association_human_name = association_reflection.klass.model_name.human
+      placeholder = "NEW_#{association_human_name.upcase.split(' ').join('_')}_RECORD"
+
+      js = with_new_form_buffer do
+        inputs_for_nested_attributes :for => [association, association_reflection.klass.new],
+                                     :class => "inputs has_many_fields",
+                                     :for_options => { :child_index => placeholder },
+                                     &form_block
+      end
+
+      js = template.escape_javascript(js)
+
+      text = I18n.t 'active_admin.has_many_new', :model => association_human_name
+      onclick = "$(this).before('#{js}'.replace(/#{placeholder}/g, new Date().getTime())); return false;"
+
+      template.link_to text, "#",
+                       :onclick => onclick,
+                       :class => "button"
+    end
+
   end
 end

spec/unit/form_builder_spec.rb

@@ -338,6 +338,10 @@ def build_form(options = {}, form_object = Post.new, &block)
         Capybara.string(body).should have_css(".has_many > fieldset > ol > li > a", :class => "button", :href => "#", :content => "Delete")
       end
 
+      it "should include the nested record's class name in the js" do
+        body.should have_tag("a", :attributes => { :onclick => /NEW_POST_RECORD/ })
+      end
+
       it "should add a link to add new nested records" do
         Capybara.string(body).should have_css(".has_many > fieldset > ol > li > a", :class => "button", :href => "#", :content => "Add New Post")
       end