Logic failure when checking for auth_override

franksierra · franksierra · commit 56ed45bfffd7 · 2016-02-12T12:41:18.000-05:00
if auth_override is true it shall not pass
diff --git a/application/libraries/REST_Controller.php b/application/libraries/REST_Controller.php
@@ -540,7 +540,7 @@ public function __construct($config = 'rest')
         }
 
         // When there is no specific override for the current class/method, use the default auth value set in the config
-        if ($this->auth_override === FALSE && !($this->config->item('rest_enable_keys') && $this->_allow === TRUE) || ($this->config->item('allow_auth_and_keys') === TRUE && $this->_allow === TRUE))
+        if ($this->auth_override === FALSE && (!($this->config->item('rest_enable_keys') && $this->_allow === TRUE) || ($this->config->item('allow_auth_and_keys') === TRUE && $this->_allow === TRUE)))
         {
             $rest_auth = strtolower($this->config->item('rest_auth'));
             switch ($rest_auth)

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ public function __construct($config = 'rest')`
`540`	`540`	`}`
`541`	`541`
`542`	`542`	`// When there is no specific override for the current class/method, use the default auth value set in the config`
`543`		`- if ($this->auth_override === FALSE && !($this->config->item('rest_enable_keys') && $this->_allow === TRUE) \|\| ($this->config->item('allow_auth_and_keys') === TRUE && $this->_allow === TRUE))`
	`543`	`+ if ($this->auth_override === FALSE && (!($this->config->item('rest_enable_keys') && $this->_allow === TRUE) \|\| ($this->config->item('allow_auth_and_keys') === TRUE && $this->_allow === TRUE)))`
`544`	`544`	`{`
`545`	`545`	`$rest_auth = strtolower($this->config->item('rest_auth'));`
`546`	`546`	`switch ($rest_auth)`