refactor: with rubocop

Author: Stef-Rousset

.rubocop.yml

@@ -1,3 +1,5 @@
+require: rubocop-factory_bot
+
 inherit_from:
   - .rubocop_ruby.yml
   - .rubocop_rails.yml
@@ -19,4 +21,4 @@ AllCops:
 
 RSpec/DescribeClass:
   Exclude:
-    - spec/system/*
+    - spec/system/*

.rubocop_ruby.yml

@@ -975,9 +975,10 @@ Style/SymbolArray:
 Style/SymbolProc:
   # A list of method names to be ignored by the check.
   # The names should be fairly unique, otherwise you'll end up ignoring lots of code.
-  IgnoredMethods:
-    - respond_to
-    - define_method
+  Enabled: true
+  Exclude:
+  - respond_to
+  - define_method
 
 Style/TernaryParentheses:
   EnforcedStyle: require_no_parentheses

app/jobs/decidim/cleaner/clean_admin_logs_job.rb

@@ -10,7 +10,7 @@ def perform
           next unless organization.delete_admin_logs?
 
           Decidim::ActionLog.where(organization:)
-                            .where("created_at < ?", delete_admin_logs_before_date(organization))
+                            .where(created_at: ...delete_admin_logs_before_date(organization))
                             .delete_all
         end
       end

app/jobs/decidim/cleaner/clean_deleted_users_data_job.rb

@@ -18,7 +18,7 @@ def remove_versions_for_deleted_users
             INNER JOIN decidim_users ON decidim_users.id = versions.item_id
               AND versions.item_type IN ('Decidim::User', 'Decidim::UserBaseEntity')
         SQL
-        ).where("deleted_at < ?", date_before_delete_user_versions).each do |version|
+        ).where(decidim_users: { deleted_at: ...date_before_delete_user_versions }).each do |version|
           version.destroy!
           Rails.logger.info "Version for user with id #{version.item_id} destroyed"
         end
@@ -31,7 +31,7 @@ def remove_versions_for_deleted_authorizations
               AND versions.item_type = 'Decidim::Authorization'
           SQL
         ).where(item_type: "Decidim::Authorization", decidim_authorizations: { id: nil })
-                           .where("versions.created_at < ?", date_before_delete_authorization_versions)
+                           .where(versions: { created_at: ...date_before_delete_authorization_versions })
                            .each do |version|
           version.destroy!
           Rails.logger.info "Version for authorization with id #{version.item_id} destroyed"

app/jobs/decidim/cleaner/clean_inactive_users_job.rb

@@ -12,11 +12,11 @@ def perform
           send_warning(Decidim::User.unscoped.where(organization: organization)
                                     .not_deleted
                                     .where.not(email: "")
-                                    .where("current_sign_in_at < ?", email_inactive_before_date(organization)))
+                                    .where(current_sign_in_at: ...email_inactive_before_date(organization)))
           delete_user_and_send_email(Decidim::User.unscoped.where(organization: organization)
                                                   .not_deleted
                                                   .where.not(email: "")
-                                                  .where("warning_date < ?", delete_inactive_before_date(organization)))
+                                                  .where(warning_date: ...delete_inactive_before_date(organization)))
         end
       end
 

lib/decidim/cleaner/engine.rb

@@ -8,7 +8,6 @@ module Cleaner
     # This is the engine that runs on the public interface of cleaner.
     class Engine < ::Rails::Engine
       isolate_namespace Decidim::Cleaner
-
     end
   end
 end