Fix stringifyInfo() to correctly accept the space parameter from options

Author: lahmatiy

CHANGELOG.md

@@ -1,3 +1,7 @@
+## next
+
+- Fixed `stringifyInfo()` to correctly accept the `space` parameter from options, i.e. `stringifyInfo(data, { space: 2 })`
+
 ## 0.6.1 (2024-08-06)
 
 - Enhanced the performance of `stringifyChunked()` by 1.5-3x

src/stringify-cases.js

@@ -110,7 +110,7 @@ export const tests = [
 ];
 export const spaceTests = tests
     .filter(t => typeof t === 'object')
-    .concat('foo', 123, null, false);
+    .concat('foo', 123, false);
 export const replacerTests = [
     [1, () => 2],
     [{ a: undefined }, (k, v) => {

src/stringify-chunked.test.js

@@ -17,8 +17,7 @@ function testTitleWithValue(title) {
 
 function createStringifyTestFn(input, expected, ...args) {
     return () => {
-        const chunks = [...stringifyChunked(input, ...args)];
-        const actual = chunks.join('');
+        const actual = [...stringifyChunked(input, ...args)].join('');
 
         if (actual !== expected) {
             const escapedActual = JSON.stringify(actual);
@@ -166,6 +165,19 @@ describe('stringifyChunked()', () => {
         });
     });
 
+    it('options', () => {
+        const actual = [...stringifyChunked({ foo: 123, bar: 456 }, {
+            highWaterMark: 1,
+            replacer: ['foo'],
+            space: 4
+        }, 2)]; // should ignore third argument when options passed
+
+        assert.deepStrictEqual(actual, [
+            '{\n    "foo": 123',
+            '\n}'
+        ]);
+    });
+
     describe('circular structure', () => {
         it('{ a: $ } should emit error when object refers to ancestor object', () => {
             const circularRef = {};

src/stringify-info.js

@@ -149,7 +149,7 @@ export function stringifyInfo(value, optionsOrReplacer, space) {
         replacer = null;
     }
 
-    space = spaceLength(space);
+    space = spaceLength(optionsOrReplacer.space);
 
     const keysLength = new Map();
     const visited = new Map();

src/stringify-info.test.js

@@ -53,6 +53,18 @@ describe('stringifyInfo()', () => {
         }
     });
 
+    it('options', () => {
+        const actual = stringifyInfo({ foo: 123, bar: 456 }, {
+            replacer: ['foo'],
+            space: 4
+        }, 2); // should ignore third argument when options passed
+
+        assert.deepStrictEqual(actual, {
+            bytes: 18,
+            circular: []
+        });
+    });
+
     describe('circular', () => {
         it('should stop on first circular reference by default', () => {
             const circularRef = {};