[api] even more correct eager loading

Author: adrianschroeter

src/api/lib/xpath_engine.rb

@@ -304,8 +304,10 @@ def find(xpath)
     when 'issues'
       relation = Issue.all
     when 'binaries'
-      relation = BinaryRelease.includes(repository:[{product_medium: [{product: [{package: :project}]}]}])
-#      relation = BinaryRelease.all
+      relation = BinaryRelease.includes(
+                    :repository => [ {:product_medium => {:product => {:package => :project}}},
+                                     {:product_update_repositories => :product} ])
+
       @joins = ['LEFT JOIN repositories AS release_repositories ON binary_releases.repository_id = release_repositories.id',
                  'LEFT JOIN projects AS release_projects ON release_repositories.db_project_id = release_projects.id'] << @joins
       order = :binary_releasetime

src/api/test/functional/binary_release_test.rb

@@ -86,6 +86,7 @@ def test_search_binary_release_in_fixtures
     assert_response :success
     assert_xml_tag :tag => "binary", :attributes => { :project => "BaseDistro3", :repository => "BaseDistro3_repo", :name => "package", :version => "1.0", :release => "1", :arch => "i586"}
     assert_xml_tag :tag => "updatefor", :attributes => { project: "BaseDistro", product: "fixed" }
+    assert_xml_tag :tag => "product", :attributes => { project: "BaseDistro", name: "fixed", medium: "DVD" }
 
   end