Incorrect service rebuilding

[joshwget]

Any service that has a relative volume will always be recreated regardless of whether or not the service has actually changed. The underlying issue is that docker.Convert changes the service after the hash has been calculated. This means the service will appear to be out of sync and so recreation is always triggered.

There might be other cases where docker.Convert modifies the service config, in which case the same problem will occur there as well.

[vdemeester]

@joshwget on the volume think, I think it was https://github.com/docker/libcompose/pull/339/files#diff-33042a808eb9153e032b7eb06ed82b0eL72 right 👼 ?

Anyway, I feel we should refactor a little bit this part to not update the service config once it's parsed and thus do the different lookup (ResourceLookup, …) earlier.

[joshwget]

That's exactly what I was thinking. Maybe this can be done around the same time as moving docker.Convert to its own package.

[lussoluca]

Any quick solution to this problem?