Merge pull request dokuwiki#4462 from dregad/i4461-dwpage-dir-warning

splitbrain · web-flow · commit 185b6660709a · 2025-06-19T17:26:55.000+02:00
dwpage: Detect that workingfile is a directory
diff --git a/bin/dwpage.php b/bin/dwpage.php
@@ -217,6 +217,10 @@ protected function commandCheckout($wiki_id, $localfile)
             $localfile = getcwd() . '/' . PhpString::basename($wiki_fn);
         }
 
+        if (is_dir($localfile)) {
+            $this->fatal("Working file $localfile cannot be a directory");
+        }
+
         if (!file_exists(dirname($localfile))) {
             $this->fatal("Directory " . dirname($localfile) . " does not exist");
         }

Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,10 @@ protected function commandCheckout($wiki_id, $localfile)`
`217`	`217`	`$localfile = getcwd() . '/' . PhpString::basename($wiki_fn);`
`218`	`218`	`}`
`219`	`219`
	`220`	`+ if (is_dir($localfile)) {`
	`221`	`+ $this->fatal("Working file $localfile cannot be a directory");`
	`222`	`+ }`
	`223`	`+`
`220`	`224`	`if (!file_exists(dirname($localfile))) {`
`221`	`225`	`$this->fatal("Directory " . dirname($localfile) . " does not exist");`
`222`	`226`	`}`