[CleanRepo] remove-hops doesn't handle monikers in redirect file

[Mikejo5000]

CleanRepo doesn't handle monikered redirects well. The following causes a "same key" error when there's another redirect with the same source_path but a different moniker value (vs-2022):

{
"source_path": "docs/install/visual-studio-build-numbers-and-release-dates.md",
"redirect_url": "/visualstudio/releases/2019/history#release-dates-and-build-numbers",
"redirect_document_id": false,
"monikers": [
"vs-2019"
]
}

[gewarren]

@Mikejo5000 This is happening because you have two redirects for the same file:

1. https://github.com/MicrosoftDocs/visualstudio-docs-pr/blob/f6dc881f5b4fa8a7300d27cefaa0a6d53303b5ba/.openpublishing.redirection.vs2017.json#L39585
2. https://github.com/MicrosoftDocs/visualstudio-docs-pr/blob/f6dc881f5b4fa8a7300d27cefaa0a6d53303b5ba/.openpublishing.redirection.vs2017.json#L42686

One could argue that CleanRepo should handle it better though, so I'll leave this issue open. But you could remove one of those redirects for now and then rerun the tool.

[Mikejo5000]

@gewarren Great, thanks! I'll try it out

[Mikejo5000]

@gewarren Genevieve, do you know what this error means? I don't see anything wrong with line 905 in the redirection file.

Removing hops from the '.openpublishing.redirection.json' redirection file.
Caught exception while reading the C:\git-repos\visualstudio-docs-pr.openpublishing.redirection.json file: The JSON value could not be converted to System.Nullable`1[System.Boolean]. Path: $.redirections[180].redirect_document_id | LineNumber: 905 | BytePositionInLine: 37. Cannot get the value of a token type 'String' as a boolean.
Deserialization of redirection file failed.

[gewarren]

@Mikejo5000 Probably means you have true or false in quotes. Should look like this instead: https://github.com/dotnet/docs/blob/b74766942f2d9c52375d29c515be9fdcaced4d4b/.openpublishing.redirection.csharp.json#L230

[Mikejo5000]

Yes, that looks right. Thanks!

[Mikejo5000]

It appears that the tool is not handling monikered redirects well. The following causes a "same key" error when there's another redirect with the same source_path but a different moniker value (vs-2022):
{
"source_path": "docs/install/visual-studio-build-numbers-and-release-dates.md",
"redirect_url": "/visualstudio/releases/2019/history#release-dates-and-build-numbers",
"redirect_document_id": false,
"monikers": [
"vs-2019"
]
},

[gewarren]

@Mikejo5000 Okay, thank you. Let's track that with this issue. I'll update the title.