JSON deserialization errors in C# 'REST Client' tutorial

[StuartMosquera]

Type of issue

Code doesn't work

Description

When running the final code, the properties GitHubHomeUrl and LastPushUtc don't display correctly. This seems to be caused by a mismatch between property names and JSON keys.

Page URL

https://learn.microsoft.com/en-us/dotnet/csharp/tutorials/console-webapiclient

Content source URL

https://github.com/dotnet/docs/blob/main/docs/csharp/tutorials/console-webapiclient.md

Document Version Independent Id

5415878b-e60b-5433-7b4b-efc8259908f0

Platform Id

1818f1ab-6db8-c7f8-1cb5-796181029761

Article author

@BillWagner

Metadata

• ID: 3bfcc1a8-ddda-810c-17b0-56a506045d67
• PlatformId: 1818f1ab-6db8-c7f8-1cb5-796181029761
• Service: dotnet-csharp
• Sub-service: fundamentals

Related Issues

[mozhganEtaati]

I tested this and confirmed that the issue is caused by mismatched property names in the deserialization model.

If you replace the model with the following version, the values display correctly:

using System.Text.Json.Serialization;

public record class Repository(
    string Name,
    string Description,
    [property: JsonPropertyName("html_url")] Uri GitHubHomeUrl,
    Uri Homepage,
    int Watchers,
    [property: JsonPropertyName("pushed_at")] DateTime LastPushUtc)
{
    public DateTime LastPush => LastPushUtc.ToLocalTime();
}

This version correctly maps the JSON fields html_url and pushed_at from the GitHub API,
And the output now shows both GitHubHomeUrl and LastPush as expected.

[StuartMosquera]

@mozhganEtaati Could you submit a PR to apply your fix?

[mozhganEtaati]

Yes, sure! I’ll submit a PR to apply the fix.

[AmirHosseinHasanloo]

Hi, I'd like to work on this issue if it's available.
I'm new to contributing to dotnet/docs and this looks like a good first issue for me.

[StuartMosquera]

Hi @AmirHosseinHasanloo, this issue already has an approved PR.
If you'd like to contribute, look for other ones labeled good first issue or help wanted. That's a great way to start.

[AmirHosseinHasanloo]

Hi @AmirHosseinHasanloo, this issue already has an approved PR. If you'd like to contribute, look for other ones labeled good first issue or help wanted. That's a great way to start.

Got it, thanks! I’ll look for another beginner-friendly issue to work on. :)