Fix parameter types for id in issue, issue category and time entry

Author: Art4

src/Redmine/Api/Issue.php

@@ -219,22 +219,22 @@ public function update($id, array $params)
     }
 
     /**
-     * @param int    $id
-     * @param string $watcherUserId
+     * @param int $id
+     * @param int $watcherUserId
      *
      * @return false|string
      */
     public function addWatcher($id, $watcherUserId)
     {
         return $this->post(
             '/issues/' . urlencode(strval($id)) . '/watchers.xml',
-            XmlSerializer::createFromArray(['user_id' => $watcherUserId])->getEncoded()
+            XmlSerializer::createFromArray(['user_id' => urlencode(strval($watcherUserId))])->getEncoded()
         );
     }
 
     /**
-     * @param int    $id
-     * @param string $watcherUserId
+     * @param int $id
+     * @param int $watcherUserId
      *
      * @return false|\SimpleXMLElement|string
      */

src/Redmine/Api/IssueCategory.php

@@ -125,13 +125,13 @@ public function getIdByName($project, $name)
      *
      * @see http://www.redmine.org/projects/redmine/wiki/Rest_IssueCategories#GET-2
      *
-     * @param string $id the issue category id
+     * @param int $id the issue category id
      *
      * @return array information about the category
      */
     public function show($id)
     {
-        return $this->get('/issue_categories/' . urlencode($id) . '.json');
+        return $this->get('/issue_categories/' . urlencode(strval($id)) . '.json');
     }
 
     /**
@@ -171,7 +171,7 @@ public function create($project, array $params = [])
      *
      * @see http://www.redmine.org/projects/redmine/wiki/Rest_IssueCategories#PUT
      *
-     * @param string $id the issue category id
+     * @param int $id the issue category id
      *
      * @return string|false
      */
@@ -184,7 +184,7 @@ public function update($id, array $params)
         $params = $this->sanitizeParams($defaults, $params);
 
         return $this->put(
-            '/issue_categories/' . $id . '.xml',
+            '/issue_categories/' . urlencode(strval($id)) . '.xml',
             XmlSerializer::createFromArray(['issue_category' => $params])->getEncoded()
         );
     }
@@ -204,7 +204,7 @@ public function update($id, array $params)
     public function remove($id, array $params = [])
     {
         return $this->delete(
-            PathSerializer::create('/issue_categories/' . $id . '.xml', $params)->getPath()
+            PathSerializer::create('/issue_categories/' . urlencode(strval($id)) . '.xml', $params)->getPath()
         );
     }
 }

src/Redmine/Api/IssueRelation.php

@@ -83,7 +83,7 @@ public function all($issueId, array $params = [])
      */
     public function show($id)
     {
-        $ret = $this->get('/relations/' . urlencode($id) . '.json');
+        $ret = $this->get('/relations/' . urlencode(strval($id)) . '.json');
         if (false === $ret) {
             return [];
         }
@@ -126,7 +126,7 @@ public function create($issueId, array $params = [])
         $params = $this->sanitizeParams($defaults, $params);
 
         $response = $this->post(
-            '/issues/' . urlencode($issueId) . '/relations.json',
+            '/issues/' . urlencode(strval($issueId)) . '/relations.json',
             JsonSerializer::createFromArray(['relation' => $params])->getEncoded()
         );
 

src/Redmine/Api/TimeEntry.php

@@ -76,13 +76,13 @@ public function all(array $params = [])
      *
      * @see http://www.redmine.org/projects/redmine/wiki/Rest_TimeEntries
      *
-     * @param string $id the time entry id
+     * @param int $id the time entry id
      *
      * @return array information about the time entry
      */
     public function show($id)
     {
-        return $this->get('/time_entries/' . urlencode($id) . '.json');
+        return $this->get('/time_entries/' . urlencode(strval($id)) . '.json');
     }
 
     /**