Skip to content

Commit a293931

Browse files
authored
Rename iInCircle to info (elastic#8744)
1 parent 44c9ac9 commit a293931

File tree

18 files changed

+63
-37
lines changed

18 files changed

+63
-37
lines changed

packages/docusaurus-theme/src/theme/Admonition/Types.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const VARIANT_TO_PROPS_MAP: Record<
3030
> = {
3131
note: { iconType: 'paperClip', color: 'accent' },
3232
tip: { iconType: 'faceHappy', color: 'success' },
33-
info: { iconType: 'iInCircle', color: 'primary' },
33+
info: { iconType: 'info', color: 'primary' },
3434
accessibility: { iconType: 'accessibility', color: 'primary' },
3535
warning: { iconType: 'alert', color: 'warning' },
3636
danger: { iconType: 'error', color: 'danger' },
@@ -56,7 +56,7 @@ const Callout = ({ title, type, children }: Props) => {
5656
return (
5757
<EuiCallOut
5858
title={title}
59-
iconType="iInCircle"
59+
iconType="info"
6060
color="primary"
6161
{...variantProps}
6262
css={css`
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Added `info` icon glyph

packages/eui/src/components/card/card.a11y.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const Card = () => {
4747
description="Example of a short card description."
4848
footer={
4949
<EuiButtonEmpty
50-
iconType="iInCircle"
50+
iconType="info"
5151
size="xs"
5252
onClick={detailsClicked}
5353
aria-label="See more details about Sketch"
@@ -68,7 +68,7 @@ const Card = () => {
6868
description="Example of a longer card description. See how the footers stay lined up."
6969
footer={
7070
<EuiButtonEmpty
71-
iconType="iInCircle"
71+
iconType="info"
7272
size="xs"
7373
onClick={detailsClicked}
7474
aria-label="See more details about Google"
@@ -89,7 +89,7 @@ const Card = () => {
8989
description="Example of a short card description."
9090
footer={
9191
<EuiButtonEmpty
92-
iconType="iInCircle"
92+
iconType="info"
9393
size="xs"
9494
onClick={detailsClicked}
9595
aria-label="See more details about Not Adobe"

packages/eui/src/components/collapsible_nav_beta/collapsible_nav_beta.stories.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,14 @@ export const Playground: Story = {
116116
{
117117
title: 'Discover',
118118
onClick: () => action('Discover')('clicked!'),
119-
icon: 'iInCircle',
119+
icon: 'info',
120120
},
121-
{ title: 'Dashboards', href: '#', icon: 'iInCircle' },
122-
{ title: 'Visualize library', href: '#', icon: 'iInCircle' },
121+
{ title: 'Dashboards', href: '#', icon: 'info' },
122+
{ title: 'Visualize library', href: '#', icon: 'info' },
123123
]),
124124
{
125125
title: 'Machine learning',
126-
icon: 'iInCircle',
126+
icon: 'info',
127127
items: [
128128
{ title: 'Anomaly detection', href: '#' },
129129
{ title: 'Data frame analytics', href: '#' },
@@ -147,13 +147,13 @@ export const Playground: Story = {
147147
{
148148
title: 'Standalone item with long name',
149149
href: '#',
150-
icon: 'iInCircle',
150+
icon: 'info',
151151
},
152152
]),
153153
...renderGroup('Content', [
154-
{ title: 'Indices', href: '#', icon: 'iInCircle' },
155-
{ title: 'Transforms', href: '#', icon: 'iInCircle' },
156-
{ title: 'Indexing API', href: '#', icon: 'iInCircle' },
154+
{ title: 'Indices', href: '#', icon: 'info' },
155+
{ title: 'Transforms', href: '#', icon: 'info' },
156+
{ title: 'Indexing API', href: '#', icon: 'info' },
157157
]),
158158
...renderGroup('Security', [
159159
{ title: 'API keys', href: '#', icon: 'gear' },

packages/eui/src/components/icon/__snapshots__/icon.test.tsx.snap

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4713,6 +4713,34 @@ exports[`EuiIcon props type infinity is rendered 1`] = `
47134713
</svg>
47144714
`;
47154715

4716+
exports[`EuiIcon props type info is rendered 1`] = `
4717+
<svg
4718+
aria-hidden="true"
4719+
class="euiIcon emotion-euiIcon-m-isLoaded"
4720+
data-icon-type="info"
4721+
data-is-loaded="true"
4722+
height="16"
4723+
role="img"
4724+
viewBox="0 0 16 16"
4725+
width="16"
4726+
xmlns="http://www.w3.org/2000/svg"
4727+
>
4728+
<path
4729+
clip-rule="evenodd"
4730+
d="M8 14A6 6 0 1 0 8 2a6 6 0 0 0 0 12Zm0 1A7 7 0 1 0 8 1a7 7 0 0 0 0 14Z"
4731+
fill-rule="evenodd"
4732+
/>
4733+
<path
4734+
d="M9 5a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"
4735+
/>
4736+
<path
4737+
clip-rule="evenodd"
4738+
d="M6.5 7h2v4H10v1H6v-1h1.5V8h-1V7Z"
4739+
fill-rule="evenodd"
4740+
/>
4741+
</svg>
4742+
`;
4743+
47164744
exports[`EuiIcon props type inputOutput is rendered 1`] = `
47174745
<svg
47184746
aria-hidden="true"

packages/eui/src/components/icon/assets/iInCircle.tsx renamed to packages/eui/src/components/icon/assets/info.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ interface SVGRProps {
1414
title?: string;
1515
titleId?: string;
1616
}
17-
const EuiIconIInCircle = ({
17+
const EuiIconInfo = ({
1818
title,
1919
titleId,
2020
...props
@@ -41,4 +41,4 @@ const EuiIconIInCircle = ({
4141
/>
4242
</svg>
4343
);
44-
export const icon = EuiIconIInCircle;
44+
export const icon = EuiIconInfo;

packages/eui/src/components/icon/icon_glyphs.a11y.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ describe('EuiIcons', () => {
119119
'heatmap',
120120
'help',
121121
'home',
122-
'iInCircle',
122+
'info',
123123
'image',
124124
'importAction',
125125
'indexClose',

packages/eui/src/components/icon/icon_map.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,8 @@ export const typeToPathMap = {
192192
heatmap: 'heatmap',
193193
help: 'help',
194194
home: 'home',
195-
iInCircle: 'iInCircle',
195+
iInCircle: 'info', // NOTE: To be deprecated in favor of `info`
196+
info: 'info',
196197
image: 'image',
197198
importAction: 'import',
198199
index: 'index',

packages/eui/src/components/page/page_header/page_header_content.stories.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,7 @@ export const Playground: Story = {
5454
iconType: 'logoKibana',
5555
description: 'Example of a description.',
5656
children: (
57-
<EuiCallOut
58-
size="s"
59-
iconType="iInCircle"
60-
title="Example of custom children"
61-
/>
57+
<EuiCallOut size="s" iconType="info" title="Example of custom children" />
6258
),
6359
rightSideItems: [
6460
<EuiButton fill>Add something</EuiButton>,

packages/eui/src/components/table/table_header_cell.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ describe('EuiTableHeaderCell', () => {
193193
<EuiTableHeaderCell
194194
tooltipProps={{
195195
content: 'This is the content of the tooltip',
196-
icon: 'iInCircle',
196+
icon: 'info',
197197
iconProps: {
198198
'data-test-subj': 'icon',
199199
},
@@ -208,7 +208,7 @@ describe('EuiTableHeaderCell', () => {
208208

209209
expect(getByTestSubject('icon')).toHaveAttribute(
210210
'data-euiicon-type',
211-
'iInCircle'
211+
'info'
212212
);
213213

214214
fireEvent.focus(getByTestSubject('icon'));
@@ -224,7 +224,7 @@ describe('EuiTableHeaderCell', () => {
224224
<EuiTableHeaderCell
225225
tooltipProps={{
226226
content: 'This is the content of the tooltip',
227-
icon: 'iInCircle',
227+
icon: 'info',
228228
iconProps: {
229229
'data-test-subj': 'icon',
230230
},
@@ -240,7 +240,7 @@ describe('EuiTableHeaderCell', () => {
240240

241241
expect(getByTestSubject('icon')).toHaveAttribute(
242242
'data-euiicon-type',
243-
'iInCircle'
243+
'info'
244244
);
245245

246246
fireEvent.focus(getByTestSubject('tableHeaderSortButton'));

packages/website/docs/components/containers/card.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ export default () => {
283283
description="Example of a short card description."
284284
footer={
285285
<EuiButtonEmpty
286-
iconType="iInCircle"
286+
iconType="info"
287287
size="xs"
288288
onClick={detailsClicked}
289289
aria-label="See more details about Sketch"
@@ -304,7 +304,7 @@ export default () => {
304304
description="Example of a longer card description. See how the footers stay lined up."
305305
footer={
306306
<EuiButtonEmpty
307-
iconType="iInCircle"
307+
iconType="info"
308308
size="xs"
309309
onClick={detailsClicked}
310310
aria-label="See more details about Google"
@@ -325,7 +325,7 @@ export default () => {
325325
description="Example of a short card description."
326326
footer={
327327
<EuiButtonEmpty
328-
iconType="iInCircle"
328+
iconType="info"
329329
size="xs"
330330
onClick={detailsClicked}
331331
aria-label="See more details about Not Adobe"

packages/website/docs/components/display/callout.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ export default () => {
207207
{showCallOut ? (
208208
<EuiCallOut
209209
onDismiss={onDismiss}
210-
iconType="iInCircle"
210+
iconType="info"
211211
title={
212212
showTitle
213213
? 'You can dismiss this callout by clicking the Close button in the top right corner'

packages/website/docs/components/display/icons/icon_types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export const iconTypes: Array<IconType> = [
122122
'heatmap',
123123
'help',
124124
'home',
125-
'iInCircle',
125+
'info',
126126
'image',
127127
'importAction',
128128
'index',

packages/website/docs/components/display/tooltip.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ export default () => {
224224
Pass a position utility class via <EuiCode>iconProps</EuiCode> to
225225
shift for better alignment.
226226
<EuiIconTip
227-
type="iInCircle"
227+
type="info"
228228
color="subdued"
229229
content={
230230
<span>

packages/website/docs/components/forms/selection/overview.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ export const tooltipProps = {
5454
| Option exclusion |||||
5555
| Customizable option display |||||
5656
| Customizable loading/error messages |||||
57-
| Searchable | ❌ <EuiIconTip type="iInCircle" content="Native select behavior will jump to options based on user typing" {...tooltipProps} /> ||||
58-
| `disabled` state | ✅ <EuiIconTip type="iInCircle" content="Disables whole component" {...tooltipProps} /> | ✅ <EuiIconTip type="iInCircle" content="Disables individual option" {...tooltipProps} /> | ✅ <EuiIconTip type="iInCircle" content="Disables individual option" {...tooltipProps} /> | ✅ <EuiIconTip type="iInCircle" content="Disables whole component" {...tooltipProps} /> |
57+
| Searchable | ❌ <EuiIconTip type="info" content="Native select behavior will jump to options based on user typing" {...tooltipProps} /> ||||
58+
| `disabled` state | ✅ <EuiIconTip type="info" content="Disables whole component" {...tooltipProps} /> | ✅ <EuiIconTip type="info" content="Disables individual option" {...tooltipProps} /> | ✅ <EuiIconTip type="info" content="Disables individual option" {...tooltipProps} /> | ✅ <EuiIconTip type="info" content="Disables whole component" {...tooltipProps} /> |
5959
| `readOnly` state |||||
60-
| Built in utility function for clearing user input ||| ✅ <EuiIconTip type="iInCircle" content="Clears search input" {...tooltipProps} /> | ✅ <EuiIconTip type="iInCircle" content="Clears all selections" {...tooltipProps} /> |
60+
| Built in utility function for clearing user input ||| ✅ <EuiIconTip type="info" content="Clears search input" {...tooltipProps} /> | ✅ <EuiIconTip type="info" content="Clears all selections" {...tooltipProps} /> |
6161
| Supports virtualization |||||

packages/website/docs/patterns/help-content.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Concepts are more than quick definitions. They help users understand how somethi
4646

4747

4848
**Interaction**
49-
- Information icon <Icon type="iInCircle" title="information icon" /> with the `primary` color directly following the setting to explain.
49+
- Information icon <Icon type="info" title="information icon" /> with the `primary` color directly following the setting to explain.
5050
- On click, a [popover](../components/containers/popover.mdx) appears. It is dismissed by a second click outside of the popover area.
5151

5252
**Popover content**

packages/website/docs/utilities/accessibility/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ If the wrapped element is **focusable**, you must use the `showOnFocus` prop to
5151
<EuiScreenReaderOnly showOnFocus>
5252
<span>
5353
<EuiToolTip content="Information">
54-
<EuiButtonIcon iconType="iInCircle" aria-label="Information" />
54+
<EuiButtonIcon iconType="info" aria-label="Information" />
5555
</EuiToolTip>
5656
</span>
5757
</EuiScreenReaderOnly>

0 commit comments

Comments
 (0)