Skip to content

Commit ac5e15d

Browse files
authored
Update pull_request_template.md to collect more context (elastic#8770)
1 parent 67228fb commit ac5e15d

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

.github/pull_request_template.md

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,31 @@
11
## Summary
22

33
<!--
4-
Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.
4+
Provide a detailed summary of your PR. What changed? Explain how you arrived at your solution.
55
66
If this is your first PR in the EUI repo, please ensure you've fully read through our [contributing to EUI](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui#how-to-ensure-the-timely-review-of-pull-requests) wiki guide.
77
-->
88

9-
## Related issue
9+
## Why are we making this change?
1010

1111
<!--
12-
Generally, most PRs should have a related issue from the [public EUI repo](https://github.com/elastic/eui) that explain why we are making changes.
12+
Generally, most PRs should have a related issue from the [public EUI repo](https://github.com/elastic/eui) that explain **why** we are making changes.
1313
14-
If this is a small change that does *not* have an issue associated with, please clearly explain *why* we are making this change. Our future selves will thank you.
14+
If this change does *not* have an issue associated with, or it is not clear in the issue, please clearly explain *why* we are making this change. This is valuable context for our changelogs.
15+
-->
16+
17+
## Screenshots
18+
19+
<!--
20+
If this change includes changes to UI, it is important to include screenshots or gif. This helps our users understand what changed when reviewing our changelogs.
21+
-->
22+
23+
## Impact to users
24+
25+
<!--
26+
How will this change impact EUI users? If it's a breaking change, what will they need to do to handle this change when upgrading? Take a moment to look at usage in Kibana and consider how many usages this will impact and note it here.
27+
28+
Even if it is not a breaking change, how significant is the visual change? Is it a large enough visual change that we would want them advise them to test it?
1529
-->
1630

1731
## QA

0 commit comments

Comments
 (0)