Merge pull request parse-community#750 from ParsePlatform/nlutsenko.warnings

Fix static analyzer warnings.

Author: nlutsenko

Parse/Internal/LocalDataStore/SQLite/PFSQLiteStatement.h

@@ -18,7 +18,7 @@ typedef struct sqlite3_stmt sqlite3_stmt;
 
 @interface PFSQLiteStatement : NSObject
 
-@property (nonatomic, assign, readonly) sqlite3_stmt *sqliteStatement;
+@property (nullable, nonatomic, assign, readonly) sqlite3_stmt *sqliteStatement;
 @property (nonatomic, strong, readonly) dispatch_queue_t databaseQueue;
 
 - (instancetype)initWithStatement:(sqlite3_stmt *)stmt queue:(dispatch_queue_t)databaseQueue;

Parse/Internal/LocalDataStore/SQLite/PFSQLiteStatement.m

@@ -36,7 +36,7 @@ - (BOOL)close {
         }
 
         int resultCode = sqlite3_finalize(_sqliteStatement);
-        _sqliteStatement = nil;
+        _sqliteStatement = NULL;
 
         return (resultCode == SQLITE_OK || resultCode == SQLITE_DONE);
     });

Parse/Internal/PFCoreDataProvider.h

@@ -48,7 +48,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 @protocol PFObjectFilePersistenceControllerProvider <NSObject>
 
-@property (nonatomic, strong, readonly) PFObjectFilePersistenceController *objectFilePersistenceController;
+@property (null_resettable, nonatomic, strong, readonly) PFObjectFilePersistenceController *objectFilePersistenceController;
 
 @end
 

Parse/Internal/PFDataProvider.h

@@ -49,7 +49,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 @protocol PFEventuallyQueueProvider <NSObject>
 
-@property (nonatomic, strong, readonly) PFEventuallyQueue *eventuallyQueue;
+@property (null_resettable, nonatomic, strong, readonly) PFEventuallyQueue *eventuallyQueue;
 
 @end
 

Parse/PFQuery.m

@@ -669,20 +669,15 @@ + (instancetype)queryWithClassName:(NSString *)className predicate:(NSPredicate
     return [self queryWithClassName:className normalizedPredicate:normalizedPredicate];
 }
 
-+ (instancetype)orQueryWithSubqueries:(NSArray *)queries {
-    NSMutableArray *array = [NSMutableArray array];
-    NSString *className = nil;
-    for (id object in queries) {
-        PFParameterAssert([object isKindOfClass:[PFQuery class]],
++ (instancetype)orQueryWithSubqueries:(NSArray<PFQuery *> *)queries {
+    PFParameterAssert(queries.count, @"Can't create an `or` query from no subqueries.");
+    NSMutableArray *array = [NSMutableArray arrayWithCapacity:queries.count];
+    NSString *className = queries.firstObject.parseClassName;
+    for (PFQuery *query in queries) {
+        PFParameterAssert([query isKindOfClass:[PFQuery class]],
                           @"All elements should be instances of `PFQuery` class.");
-
-        PFQuery *query = (PFQuery *)object;
-        if (!className) {
-            className = query.parseClassName;
-        } else {
-            PFParameterAssert([query.parseClassName isEqualToString:className],
-                              @"All sub queries of an `or` query should be on the same class.");
-        }
+        PFParameterAssert([query.parseClassName isEqualToString:className],
+                          @"All sub queries of an `or` query should be on the same class.");
 
         [array addObject:query];
     }