Skip to content

Commit 51ed9fa

Browse files
committed
Work with Sprockets 4
1 parent 990753a commit 51ed9fa

File tree

5 files changed

+22
-10
lines changed

5 files changed

+22
-10
lines changed

.travis.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ gemfile:
1818
- gemfiles/rails50_ember_latest.gemfile
1919
- gemfiles/rails51_ember_latest.gemfile
2020
- gemfiles/sprockets_3.gemfile
21+
- gemfiles/sprockets_4.gemfile
2122
- gemfiles/sprockets_rails_3.gemfile
2223
matrix:
2324
exclude:
@@ -29,6 +30,8 @@ matrix:
2930
gemfile: gemfiles/rails50_ember_latest.gemfile
3031
- rvm: 2.1
3132
gemfile: gemfiles/rails51_ember_latest.gemfile
33+
- rvm: 2.1
34+
gemfile: gemfiles/sprockets_4.gemfile
3235
- rvm: jruby-9.1.0.0
3336
gemfile: gemfiles/rails50_ember_113.gemfile
3437
- rvm: jruby-9.1.0.0
@@ -37,5 +40,7 @@ matrix:
3740
gemfile: gemfiles/rails50_ember_latest.gemfile
3841
- rvm: jruby-9.1.0.0
3942
gemfile: gemfiles/rails51_ember_latest.gemfile
43+
- rvm: jruby-9.1.0.0
44+
gemfile: gemfiles/sprockets_4.gemfile
4045
env:
4146
- JRUBY_OPTS="--server -J-Xms1500m -J-Xmx1500m -J-XX:+UseConcMarkSweepGC -J-XX:-UseGCOverheadLimit -J-XX:+CMSClassUnloadingEnabled" # see: https://github.com/jruby/jruby/issues/1320

gemfiles/sprockets_4.gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
source 'https://rubygems.org'
2+
3+
gem 'rails', '~> 5.0'
4+
gem 'ember-source', '~> 2.0'
5+
gem 'sprockets', '~> 4.0.0.beta4'
6+
7+
gemspec path: '../'

lib/ember/rails/engine.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ class Engine < ::Rails::Engine
1818
config.handlebars.ember_template = Ember::VERSION =~ /\A1.[0-9]\./ ? 'Handlebars' : 'HTMLBars'
1919
end
2020

21-
config.before_initialize do |app|
22-
Sprockets::Engines #force autoloading
23-
end
24-
2521
config.before_initialize do |app|
2622
Ember::ES6Template.configure do |ember_config|
2723
ember_config.module_prefix = config.ember.module_prefix

lib/ember_rails.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ def configure_assets(app)
100100

101101
initializer "ember_rails.setup_ember_template_compiler", :after => "ember_rails.setup_vendor", :group => :all do |app|
102102
configure_assets app do |env|
103-
Ember::Handlebars::Template.setup_ember_template_compiler(env.resolve('ember-template-compiler.js'))
103+
# Ember::Handlebars::Template.setup_ember_template_compiler(env.resolve('ember-template-compiler.js'))
104+
Ember::Handlebars::Template.setup_ember_template_compiler(env.find_asset('ember-template-compiler.js').filename)
104105
end
105106
end
106107

test/dummy/config/environments/test.rb

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,16 @@
99

1010
config.eager_load = false
1111

12-
# Configure static asset server for tests with Cache-Control for performance
13-
if Rails.version >= '4.2.0'
14-
config.serve_static_files = true
12+
if Rails::VERSION::MAJOR >= 5
13+
config.public_file_server.enabled = true
14+
config.public_file_server.headers = {
15+
'Cache-Control' => "public, max-age=#{1.hour.seconds.to_i}"
16+
}
1517
else
16-
config.serve_static_assets = true
18+
# Configure static asset server for tests with Cache-Control for performance
19+
config.serve_static_files = true
20+
config.static_cache_control = "public, max-age=3600"
1721
end
18-
config.static_cache_control = "public, max-age=3600"
1922

2023
# Log error messages when you accidentally call methods on nil
2124
config.whiny_nils = true unless Rails.version >= '4.0.0'

0 commit comments

Comments
 (0)