Stop allowing commas in fixed numbers; left over from legacy comma support (ethers-io#2083).

ricmoo · ricmoo · commit 45f367512d1d · 2021-10-04T10:48:27.000-04:00
diff --git a/packages/bignumber/src.ts/fixednumber.ts b/packages/bignumber/src.ts/fixednumber.ts
@@ -72,7 +72,7 @@ export function parseFixed(value: string, decimals?: BigNumberish): BigNumber {
     if (decimals == null) { decimals = 0; }
     const multiplier = getMultiplier(decimals);
 
-    if (typeof(value) !== "string" || !value.match(/^-?[0-9.,]+$/)) {
+    if (typeof(value) !== "string" || !value.match(/^-?[0-9.]+$/)) {
         logger.throwArgumentError("invalid decimal value", "value", value);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ export function parseFixed(value: string, decimals?: BigNumberish): BigNumber {`
`72`	`72`	`if (decimals == null) { decimals = 0; }`
`73`	`73`	`const multiplier = getMultiplier(decimals);`
`74`	`74`
`75`		`- if (typeof(value) !== "string" \|\| !value.match(/^-?[0-9.,]+$/)) {`
	`75`	`+ if (typeof(value) !== "string" \|\| !value.match(/^-?[0-9.]+$/)) {`
`76`	`76`	`logger.throwArgumentError("invalid decimal value", "value", value);`
`77`	`77`	`}`
`78`	`78`