test(pass-style): Relaxations necessary for unsafe hardenTaming test coverage

Author: kriskowal

packages/pass-style/test/atom.test.js

@@ -13,8 +13,10 @@ test('isAtom test', t => {
   const p = Promise.resolve();
   t.false(isAtom(p));
   t.throws(() => assertAtom(p), {
-    message:
-      'Not even Passable: "[Error: Cannot pass non-frozen objects like \\"[Promise]\\". Use harden()]": "[Promise]"',
+    // @ts-expect-error isFake is a secret
+    message: harden.isFake
+      ? 'A "promise" cannot be an atom: "[Promise]"'
+      : 'Not even Passable: "[Error: Cannot pass non-frozen objects like \\"[Promise]\\". Use harden()]": "[Promise]"',
   });
 
   harden(p);

packages/pass-style/test/errors.test.js

@@ -17,9 +17,12 @@ const { defineProperty } = Object;
 
 test('style of extended errors', t => {
   const e1 = Error('e1');
-  t.throws(() => passStyleOf(e1), {
-    message: 'Cannot pass non-frozen objects like "[Error: e1]". Use harden()',
-  });
+  if (!harden.isFake) {
+    t.throws(() => passStyleOf(e1), {
+      message:
+        'Cannot pass non-frozen objects like "[Error: e1]". Use harden()',
+    });
+  }
   harden(e1);
   t.is(passStyleOf(e1), 'error');
 
@@ -49,7 +52,7 @@ test('toPassableError, toThrowable', t => {
   // Since then, we changed `makeError` to make reasonable effort
   // to return a passable error by default. But also added the
   // `sanitize: false` option to suppress that.
-  t.false(Object.isFrozen(e));
+  t.false(!harden.isFake && Object.isFrozen(e));
   t.false(isPassable(e));
 
   // toPassableError hardens, and then checks whether the hardened argument

packages/pass-style/test/far-class-instances.test.js

@@ -104,7 +104,7 @@ test('far class instances', t => {
   ]);
 });
 
-test('far class instance hardened empty', t => {
+(harden.isFake ? test.skip : test)('far class instance hardened empty', t => {
   class FarClass4 extends FarBaseClass {
     z = 0;
   }

packages/pass-style/test/passStyleOf.test.js

@@ -485,6 +485,9 @@ test('Unexpected stack on errors', t => {
   err.stack = carrierStack;
   harden(err);
 
+  // Fake harden does not maintain this invariant, but when passStyleOf senses
+  // a fake harden, it takes upon itself the obligation to fix the error
+  // object.
   t.throws(() => passStyleOf(err), {
     message: 'Passable Error "stack" own property must be a string: {}',
   });