Fix some RuboCop violations

Fixed all remaining violations except for those related to length and
complexity. Those types of violations will be taken care of during the
big refactor that is soon to happen.

Author: enkessler

.rubocop_todo.yml

@@ -49,57 +49,3 @@ Metrics/ModuleLength:
 # Offense count: 1
 Metrics/PerceivedComplexity:
   Max: 10
-
-# Offense count: 1
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-Naming/PredicateName:
-  Exclude:
-    - 'spec/**/*'
-
-# Offense count: 23
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: snake_case, normalcase, non_integer
-Naming/VariableNumber:
-  Exclude:
-    - 'testing/rspec/spec/cql_spec.rb'
-    - 'testing/rspec/spec/predefined_filters_spec.rb'
-    - 'testing/rspec/spec/repository_spec.rb'
-
-
-# Offense count: 19
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# IgnoredMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'testing/rspec/spec/cql_spec.rb'
-    - 'testing/rspec/spec/line_filterable_specs.rb'
-    - 'testing/rspec/spec/name_filterable_specs.rb'
-    - 'testing/rspec/spec/queriable_specs.rb'
-
-# Offense count: 9
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-
-
-# Offense count: 1
-Style/MethodMissing:
-  Exclude:
-    - 'lib/cql/dsl.rb'
-
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
-# SupportedStyles: predicate, comparison
-Style/NumericPredicate:
-  Exclude:
-    - 'spec/**/*'

lib/cql/dsl.rb

@@ -5,7 +5,7 @@ module Dsl
 
 
     # Any undefined method is assumed to mean its String equivalent, thus allowing a more convenient query syntax.
-    def method_missing(method_name)
+    def method_missing(method_name) # rubocop:disable Style/MethodMissing - All it does is make a string. No real risk.
       method_name.to_s
     end
 

testing/rspec/spec/queriable_specs.rb

@@ -28,14 +28,14 @@
   it 'complains if a query is attempted without a query root being set' do
     object.query_root = nil
 
-    expect {
+    expect do
 
       object.query do
         select :model
         from :all
       end
 
-    }.to raise_error(ArgumentError, 'Query cannot be run. No query root has been set.')
+    end.to raise_error(ArgumentError, 'Query cannot be run. No query root has been set.')
   end
 
   it 'starts with a query root' do