Skip to content

update: local rcp urls #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 25, 2021
Merged

update: local rcp urls #35

merged 6 commits into from
Mar 25, 2021

Conversation

@platocrat
Copy link
Contributor

@platocrat platocrat commented Mar 9, 2021

Fixes #34

Questions

  1. Doesn't 127.0.0.1 map to localhost? Wondering why the IP is 0.0.0.0

@platocrat platocrat changed the title Update/local rcp urls Update local rcp urls Mar 9, 2021
@platocrat platocrat added bug Something isn't working documentation Improvements or additions to documentation labels Mar 9, 2021
@platocrat platocrat changed the title Update local rcp urls bug: Update local rcp urls Mar 9, 2021
tynes
tynes reviewed Mar 9, 2021
View reviewed changes
@platocrat platocrat self-assigned this Mar 9, 2021
@platocrat
Copy link
Contributor Author

platocrat commented Mar 10, 2021 •
edited
Loading

Realized better network names:

@platocrat platocrat added enhancement New feature or request and removed bug Something isn't working labels Mar 10, 2021
@platocrat platocrat changed the title bug: Update local rcp urls update: local rcp urls Mar 10, 2021
@platocrat platocrat added update Updating out-of-date stuff and removed enhancement New feature or request labels Mar 10, 2021
@maurelian maurelian marked this pull request as draft March 11, 2021 21:20
@platocrat platocrat mentioned this pull request Mar 23, 2021
Merged
@platocrat platocrat marked this pull request as ready for review March 23, 2021 21:05
@platocrat platocrat removed request for K-Ho and maurelian March 24, 2021 00:02
smartcontracts
smartcontracts reviewed Mar 24, 2021
View reviewed changes
smartcontracts
smartcontracts reviewed Mar 24, 2021
View reviewed changes
smartcontracts
smartcontracts reviewed Mar 25, 2021
View reviewed changes
@smartcontracts smartcontracts merged commit 7287132 into experimental Mar 25, 2021
@smartcontracts smartcontracts deleted the update/local-rcp-urls branch March 25, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

+2 more reviewers

@tynes tynes tynes left review comments

@maurelian maurelian maurelian left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@platocrat platocrat

Labels

documentation Improvements or additions to documentation update Updating out-of-date stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local RPC url and chainID are incorrect when creating custom network on MetaMask

5 participants

@platocrat @tynes @smartcontracts @maurelian