common: hardforks() method has dead code

[ScottyPoi]

The hardforks() method in the Common class contains a conditional check that doesn't actually do anything. The method checks if customHardforks is defined but doesn't use the result to modify the return value.

ethereumjs-monorepo/packages/common/src/common.ts

Lines 735 to 741 in e308102

	hardforks(): HardforkTransitionConfig[] {
	const hfs = this._chainParams.hardforks
	if (this._chainParams.customHardforks !== undefined) {
	this._chainParams.customHardforks
	}
	return hfs
	}

[ScottyPoi]

I assume the intention here was to return this._chainParams.customHardforks

For this we'd either have to update the return type ( and handle downstream ), or convert this._chainParams.customHardforks into a HardforkTransitionConfig[].

Or, we could just delete this conditional, since it's not doing anything.

[holgerd77]

I'm not sure if this custom HF functionality is still relevant, we would need to have a look.

Also note there is already an issue out there mentioning this code part (would be good to reference and then close both at some point).