Skip to content

Commit 6dafbdc

Browse files
authored
Merge pull request coreos#258 from muesli/journal-shadow-fix
sdjournal: avoid unneeded variable shadowing
2 parents 2ba91c6 + 95af4d3 commit 6dafbdc

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

sdjournal/read.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -135,14 +135,10 @@ func NewJournalReader(config JournalReaderConfig) (*JournalReader, error) {
135135
// don't fit in the read buffer. Callers should keep calling until 0 and/or an
136136
// error is returned.
137137
func (r *JournalReader) Read(b []byte) (int, error) {
138-
var err error
139-
140138
if r.msgReader == nil {
141-
var c uint64
142-
143139
// Advance the journal cursor. It has to be called at least one time
144140
// before reading
145-
c, err = r.journal.Next()
141+
c, err := r.journal.Next()
146142

147143
// An unexpected error
148144
if err != nil {
@@ -160,18 +156,15 @@ func (r *JournalReader) Read(b []byte) (int, error) {
160156
}
161157

162158
// Build a message
163-
var msg string
164-
msg, err = r.formatter(entry)
165-
159+
msg, err := r.formatter(entry)
166160
if err != nil {
167161
return 0, err
168162
}
169163
r.msgReader = strings.NewReader(msg)
170164
}
171165

172166
// Copy and return the message
173-
var sz int
174-
sz, err = r.msgReader.Read(b)
167+
sz, err := r.msgReader.Read(b)
175168
if err == io.EOF {
176169
// The current entry has been fully read. Don't propagate this
177170
// EOF, so the next entry can be read at the next Read()

0 commit comments

Comments
 (0)