sonar rules (spring-media#39)

* sonar rules

Author: chgohlke

index.ts

@@ -56,8 +56,10 @@ export const handler = (routeConfig: RouteConfig) => {
 
 const extractEventProcessorMapping = (routeConfig: RouteConfig) => {
   const processorMap = new Map<string, EventProcessor>()
-  for (let key of Object.keys(routeConfig)) {
-    if (key === 'debug') continue
+  for (const key of Object.keys(routeConfig)) {
+    if (key === 'debug') {
+      continue
+    }
     try {
       processorMap.set(key, require(`./lib/${key}`))
     } catch (error) {

lib/proxyIntegration.ts

@@ -115,8 +115,8 @@ export const process: ProcessMethod<ProxyIntegrationConfig, APIGatewayProxyEvent
     if (proxyIntegrationConfig.proxyPath) {
       event.path = (event.pathParameters || {})[proxyIntegrationConfig.proxyPath]
       if (proxyIntegrationConfig.debug) {
-        console.log('proxy path is set: ' + proxyIntegrationConfig.proxyPath)
-        console.log('proxy path with event path: ' + event.path)
+        console.log(`proxy path is set: ${proxyIntegrationConfig.proxyPath}`)
+        console.log(`proxy path with event path: ${event.path}`)
       }
     } else {
       event.path = normalizeRequestPath(event)
@@ -206,7 +206,7 @@ const findMatchingActionConfig = (httpMethod: string, httpPath: string, routeCon
 
   const paths: ProxyIntegrationParams['paths'] = {}
   const matchingMethodRoutes = routeConfig.routes.filter(route => route.method === httpMethod)
-  for (let route of matchingMethodRoutes) {
+  for (const route of matchingMethodRoutes) {
     if (routeConfig.debug) {
       console.log(`Examining route ${route.path} to match ${httpPath}`)
     }
@@ -221,7 +221,7 @@ const findMatchingActionConfig = (httpMethod: string, httpPath: string, routeCon
       }
       return {
         action: route.action,
-        paths: paths
+        paths
       }
     }
   }
@@ -233,13 +233,15 @@ const findMatchingActionConfig = (httpMethod: string, httpPath: string, routeCon
 }
 
 const extractPathValues = (pathExpression: string, httpPath: string) => {
-  const pathValueRegex = new RegExp('^' + pathExpression.replace(/{[\w]+}|:[\w]+/g, '([^/]+)') + '$')
+  const pathExpressionPattern = pathExpression.replace(/{[\w]+}|:[\w]+/g, '([^/]+)')
+  const pathValueRegex = new RegExp(`^${pathExpressionPattern}$`)
   const pathValues = pathValueRegex.exec(httpPath)
   return pathValues && pathValues.length > 0 ? pathValues.slice(1) : null
 }
 
 const extractPathNames = (pathExpression: string) => {
-  const pathNameRegex = new RegExp('^' + pathExpression.replace(/{[\w.]+}|:[\w.]+/g, '[:{]([\\w]+)}?') + '$')
+  const pathExpressionPattern = pathExpression.replace(/{[\w.]+}|:[\w.]+/g, '[:{]([\\w]+)}?')
+  const pathNameRegex = new RegExp(`^${pathExpressionPattern}$`)
   const pathNames = pathNameRegex.exec(pathExpression)
   return pathNames && pathNames.length > 0 ? pathNames.slice(1) : null
 }

lib/sns.ts

@@ -26,7 +26,7 @@ export const process: ProcessMethod<SnsConfig, SnsEvent, Context, any> = (snsCon
   }
 
   const sns = event.Records[0].Sns
-  for (let routeConfig of snsConfig.routes) {
+  for (const routeConfig of snsConfig.routes) {
     if (routeConfig.subject instanceof RegExp) {
       if (routeConfig.subject.test(sns.Subject)) {
         const result = routeConfig.action(sns, context)
@@ -65,17 +65,30 @@ const cfgExample = {
           "EventVersion": "1.0",
           "EventSubscriptionArn": "arn:aws:sns:eu-west-1:933782373565:production-escenic-updates:2fdd994c-f2b7-4c2f-a2f9-da83b590e0fc",
           "Sns": {
-              "Type": "Notification",
-              "MessageId": "0629603b-448e-5366-88b4-309d651495c5",
-              "TopicArn": "arn:aws:sns:eu-west-1:933782373565:production-escenic-updates",
-              "Subject": null,
-              "Message": "{\"escenicId\":\"159526803\",\"model\":\"news\",\"status\":\"draft\"}",
-              "Timestamp": "2016-11-16T08:56:58.227Z",
-              "SignatureVersion": "1",
-              "Signature": "dtXM9BlAJJhYkVObnKmzY012kjgl4uYHEPQ1DLUalBHnPNzkDf12YeVcvHmq0SF6QbdgGwSYw0SgtsOkBiW3WSxVosqEb5xKUWIbQhlXwKdZnzekUigsgl3d231RP+9U2Cvd4QUc6klH5P+CuQM/F70LBIIv74UmR2YNMaxWxrv7Q+ETmz/TF6Y5v8Ip3+GLikbu6wQ/F5g3IHO2Lm7cLpV/74odm48SQxoolh94TdgvtYaUnxNjFVlF8Js8trbRkr7DYTogh73cTwuR77Mo+K9GlYn53txiMW5rMl3KhVdw4U3L190gtBJVwgHbqcB60pmNdEAE9f4bEOohizfPhg==",
-              "SigningCertUrl": "https://sns.eu-west-1.amazonaws.com/SimpleNotificationService-b95095beb82e8f6a046b3aafc7f4149a.pem",
-              "UnsubscribeUrl": "https://sns.eu-west-1.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=arn:aws:sns:eu-west-1:933782373565:production-escenic-updates:2fdd994c-f2b7-4c2f-a2f9-da83b590e0fc",
-              "MessageAttributes": {}
+            "Type": "Notification",
+            "MessageId": "0629603b-448e-5366-88b4-309d651495c5",
+            "TopicArn": "arn:aws:sns:eu-west-1:933782373565:production-escenic-updates",
+            "Subject": null,
+            "Message": "{\"escenicId\":\"159526803\",\"model\":\"news\",\"status\":\"draft\"}",
+            "Timestamp": "2016-11-16T08:56:58.227Z",
+            "SignatureVersion": "1",
+            "Signature": "dtXM9BlAJJhYkVObnKgHbqcB60pmNdEAE9f4bEOohizfPhg==",
+            "SigningCertUrl": "https://sns.eu-west-1.amazonaws.com/SimpleNotificationService-b95095beb82e8f6a046b3aafc7f4149a.pem",
+            "UnsubscribeUrl": "https://sns.eu-west-1.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=arn:aws:sns:eu-west-1:933782373565:production-escenic-updates:2fdd994c-f2b7-4c2f-a2f9-da83b590e0fc",
+            "MessageAttributes": '{
+                  "stringAttribute": {
+                      "Type": "String",
+                      "Value": "stringvalue"
+                  },
+                  "binaryAttribute": {
+                      "Type": "Binary",
+                      "Value": "Ym9udmFsdWU="
+                  },
+                  "arrayAttribute": {
+                      "Type": "String",
+                      "Value": "[\"value1\", \"value2\"]"
+                  }
+            }'
           }
       }
   ]

lib/sqs.ts

@@ -27,7 +27,7 @@ export const process: ProcessMethod<SqsConfig, SqsEvent, Context, any> = (sqsCon
 
   const records = event.Records
   const recordSourceArn = records[0].eventSourceARN
-  for (let routeConfig of sqsConfig.routes) {
+  for (const routeConfig of sqsConfig.routes) {
     if (routeConfig.source instanceof RegExp) {
       if (routeConfig.source.test(recordSourceArn)) {
         const result = routeConfig.action(records.map(record => record.body), context)