Skip to content

Commit cf7a9cd

Browse files
keykiRichard Doktorics
authored andcommitted
CLOUD-94865 fix NPE when rds properties are not set
1 parent d230c91 commit cf7a9cd

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

core/src/main/java/com/sequenceiq/cloudbreak/converter/RDSConfigRequestToRDSConfigConverter.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
import com.google.common.base.Strings;
1414
import com.sequenceiq.cloudbreak.api.model.RDSConfigRequest;
1515
import com.sequenceiq.cloudbreak.api.model.RdsConfigPropertyJson;
16-
import com.sequenceiq.cloudbreak.common.type.APIResourceType;
1716
import com.sequenceiq.cloudbreak.api.model.RdsType;
1817
import com.sequenceiq.cloudbreak.api.model.ResourceStatus;
18+
import com.sequenceiq.cloudbreak.common.type.APIResourceType;
1919
import com.sequenceiq.cloudbreak.domain.RDSConfig;
2020
import com.sequenceiq.cloudbreak.domain.json.Json;
2121
import com.sequenceiq.cloudbreak.service.MissingResourceNameGenerator;
@@ -43,8 +43,9 @@ public RDSConfig convert(RDSConfigRequest source) {
4343
rdsConfig.setHdpVersion(source.getHdpVersion());
4444
rdsConfig.setType(source.getType() == null ? RdsType.HIVE : source.getType());
4545
try {
46-
Json json = new Json(convertPropertiesToJson(source.getProperties()));
47-
rdsConfig.setAttributes(source.getProperties() == null ? new Json(new HashMap<>()) : json);
46+
Json json = source.getProperties() == null ? new Json(new HashMap<>())
47+
: new Json(convertPropertiesToJson(source.getProperties()));
48+
rdsConfig.setAttributes(json);
4849
} catch (JsonProcessingException ignored) {
4950
rdsConfig.setAttributes(null);
5051
}

0 commit comments

Comments
 (0)