fix(Dart1.8): fix analyzer warnings

Author: vicb

modules/change_detection/src/parser/lexer.js

@@ -385,7 +385,6 @@ class _Scanner {
 
     var last:string = input.substring(marker, this.index);
     this.advance();  // Skip terminating quote.
-    var str:string = input.substring(start, this.index);
 
     // Compute the unescaped string value.
     var unescaped:string = last;

modules/core/test/compiler/compiler_spec.js

@@ -17,7 +17,7 @@ import {Lexer} from 'change_detection/parser/lexer';
 
 export function main() {
   describe('compiler', function() {
-    var compiler, reader;
+    var reader;
 
     beforeEach( () => {
       reader = new DirectiveMetadataReader();

modules/core/test/compiler/pipeline/pipeline_spec.js

@@ -10,13 +10,6 @@ import {CompileControl} from 'core/compiler/pipeline/compile_control';
 
 export function main() {
   describe('compile_pipeline', () => {
-    var logs, pipeline, loggingStep;
-
-    beforeEach( () => {
-      logs = [];
-      loggingStep = new LoggingStep(logs);
-    });
-
     it('should walk the tree in depth first order including template contents', () => {
       var element = createElement('<div id="1"><template id="2"><span id="3"></span></template></div>');
 

modules/core/test/compiler/view_spec.js

@@ -171,7 +171,7 @@ export function main() {
       });
 
       describe('recurse over child component views', () => {
-        var view, ctx;
+        var ctx;
 
         function createComponentWithSubPV(subProtoView) {
           var pv = new ProtoView(createElement('<cmp class="ng-binding"></cmp>'), new ProtoRecordRange());
@@ -209,7 +209,7 @@ export function main() {
             () => {
           var subpv = new ProtoView(
               createElement('<div dec class="ng-binding">hello shadow dom</div>'), new ProtoRecordRange());
-          var subBinder = subpv.bindElement(
+          subpv.bindElement(
               new ProtoElementInjector(null, 0, [ServiceDependentDecorator]));
           var pv = createComponentWithSubPV(subpv);
 
@@ -227,7 +227,7 @@ export function main() {
       });
 
       describe('recurse over child templateViews', () => {
-        var ctx, view, cd;
+        var ctx, view;
         function createView(protoView) {
           ctx = new MyEvaluationContext();
           view = protoView.instantiate(ctx, null, null);
@@ -310,7 +310,7 @@ export function main() {
 
       it('should inject the protoView into the shadowDom', () => {
         var rootProtoView = ProtoView.createRootProtoView(pv, el, someComponentDirective);
-        var view = rootProtoView.instantiate(null, new Injector([]), null, true);
+        rootProtoView.instantiate(null, new Injector([]), null, true);
         expect(el.shadowRoot.childNodes[0].childNodes[0].nodeValue).toEqual('hi');
       });
     });