Skip to content

Commit 277fe60

Browse files
author
Arpit Goswami
committed
Reversing changes WL#10495 : Deprecate writing to multiple replicated engines, when at least one is non-transactional or non-composable
Reversed the previous accidental push Change-Id: I3512f03d5dafee5e17c6a0ee485de7226244dbb8
1 parent 5675df7 commit 277fe60

File tree

74 files changed

+3
-6484
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+3
-6484
lines changed

mysql-test/r/flush_read_lock.result

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1540,8 +1540,6 @@ alter table t1_temp drop column c1;
15401540
begin;
15411541
insert into t1_base values (1);
15421542
insert into t3_trans values (1);
1543-
Warnings:
1544-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t3_trans and the MyISAM table test.t1_base.
15451543
# Switching to connection 'con1'.
15461544
# The below FTWRL should not be blocked by transaction in 'default'.
15471545
flush tables with read lock;

mysql-test/r/foreign_key_myisam.result

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,6 @@ ALTER TABLE parent ENGINE=InnoDB;
180180
ERROR HY000: Table 'child' was locked with a READ lock and can't be updated
181181
UNLOCK TABLES;
182182
LOCK TABLES child WRITE, parent WRITE;
183-
Warnings:
184-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.parent and the InnoDB table test.child.
185183
ALTER TABLE parent ENGINE=InnoDB;
186184
UNLOCK TABLES;
187185
DROP TABLES child, parent;

mysql-test/r/lock_multi.result

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -963,8 +963,6 @@ UNLOCK TABLES;
963963
# 2.c) Blocks concurrent modifications to table
964964
connection default;
965965
LOCK TABLE t1 WRITE, t2 WRITE;
966-
Warnings:
967-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t1.
968966
connection con1;
969967
# Sending:
970968
INSERT INTO t1 VALUES (1);
@@ -2101,8 +2099,6 @@ i
21012099
1
21022100
connection default;
21032101
LOCK TABLE t8 WRITE;
2104-
Warnings:
2105-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t8.
21062102
connection con1;
21072103
# Sending:
21082104
SELECT * FROM t2;;
@@ -2169,15 +2165,11 @@ RELEASE_LOCK('mysqltest_lock')
21692165
1
21702166
connection con2;
21712167
# Reaping LOCK TABLE WRITE
2172-
Warnings:
2173-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t8.
21742168
UNLOCK TABLES;
21752169
#
21762170
# 7.c) Blocks concurrent modifications to table
21772171
connection default;
21782172
LOCK TABLE t7 WRITE, t8 WRITE;
2179-
Warnings:
2180-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t7.
21812173
connection con1;
21822174
# Sending:
21832175
INSERT INTO t1 VALUES (1);
@@ -2248,8 +2240,6 @@ RELEASE_LOCK('mysqltest_lock')
22482240
1
22492241
connection con2;
22502242
# Reaping LOCK TABLES WRITE
2251-
Warnings:
2252-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t8.
22532243
UNLOCK TABLES;
22542244
connection default;
22552245
# Revert effects from INSERTs
@@ -2286,8 +2276,6 @@ connection default;
22862276
COMMIT;
22872277
connection con1;
22882278
# Reap LOCK TABLES WRITE
2289-
Warnings:
2290-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t8.
22912279
UNLOCK TABLES;
22922280
connection default;
22932281
#
@@ -2317,8 +2305,6 @@ connection default;
23172305
COMMIT;
23182306
connection con1;
23192307
# Reap LOCK TABLES WRITE
2320-
Warnings:
2321-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t8.
23222308
UNLOCK TABLES;
23232309
connection default;
23242310
# Revert effects from INSERTs
@@ -2340,8 +2326,6 @@ connection con1;
23402326
UNLOCK TABLES;
23412327
connection default;
23422328
LOCK TABLES t8 WRITE;
2343-
Warnings:
2344-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t2 and the MyISAM table test.t8.
23452329
connection con1;
23462330
# Sending:
23472331
LOCK TABLES t2 WRITE;;

mysql-test/r/mix2_myisam.result

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1179,8 +1179,6 @@ CREATE TABLE t1 ( B_ID INTEGER NOT NULL PRIMARY KEY) ENGINE=MyISAM;
11791179
SET AUTOCOMMIT=0;
11801180
INSERT INTO t1 ( B_ID ) VALUES ( 1 );
11811181
INSERT INTO t2 ( NEXT_T ) VALUES ( 1 );
1182-
Warnings:
1183-
Warning 6136 Combining the storage engines MEMORY and MyISAM is deprecated, but the statement or transaction updates both the MEMORY table test.t2 and the MyISAM table test.t1.
11841182
ROLLBACK;
11851183
Warnings:
11861184
Warning 1196 Some non-transactional changed tables couldn't be rolled back
@@ -1201,8 +1199,6 @@ create table t1 (a int not null auto_increment primary key, b int, c int, key(c)
12011199
create table t2 (a int not null auto_increment primary key, b int) ENGINE = MEMORY;
12021200
insert into t1 (b) values (null),(null),(null),(null),(null),(null),(null);
12031201
insert into t2 (a) select b from t1;
1204-
Warnings:
1205-
Warning 6136 Combining the storage engines MEMORY and MyISAM is deprecated, but the statement or transaction updates both the MEMORY table test.t2 and the MyISAM table test.t1.
12061202
insert into t1 (b) select b from t2;
12071203
insert into t2 (a) select b from t1;
12081204
insert into t1 (a) select b from t2;

mysql-test/r/no_binlog_gtid_next_partially_failed_stmts.result

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ SET SESSION GTID_NEXT='MASTER_UUID:7';
190190
OPTIMIZE TABLE t1, t_non_existent;
191191
Table Op Msg_type Msg_text
192192
test.t1 optimize status Table is already up to date
193-
test.t_non_existent optimize Warning Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table mysql.gtid_executed and the MyISAM table test.t1.
194193
test.t_non_existent optimize Error Table 'test.t_non_existent' doesn't exist
195194
test.t_non_existent optimize status Operation failed
196195
#
@@ -231,7 +230,6 @@ SET SESSION GTID_NEXT='MASTER_UUID:9';
231230
REPAIR TABLE t1, t_non_existent;
232231
Table Op Msg_type Msg_text
233232
test.t1 repair status OK
234-
test.t_non_existent repair Warning Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table mysql.gtid_executed and the MyISAM table test.t1.
235233
test.t_non_existent repair Error Table 'test.t_non_existent' doesn't exist
236234
test.t_non_existent repair status Operation failed
237235
#

mysql-test/r/partition_innodb_semi_consistent.result

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@ SELECT * FROM t1;
103103
a b
104104
1 init+con1
105105
# Switch to connection con2
106-
Warnings:
107-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t2 and the InnoDB table test.t1.
108106
SELECT * FROM t1;
109107
a b
110108
1 init+con1+con2
@@ -132,8 +130,6 @@ SELECT * FROM t1;
132130
a b
133131
2 init+con1
134132
# Switch to connection con2
135-
Warnings:
136-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t2 and the InnoDB table test.t1.
137133
SELECT * FROM t1;
138134
a b
139135
2 init+con1

mysql-test/r/rename_debug_myisam.result

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ CREATE TABLE t0 (m INT) ENGINE=MyISAM;
2424
# from the set of locked tables. Metadata locks on both
2525
# old and new table names are kept.
2626
LOCK TABLES t1 WRITE, t2 WRITE, t0 WRITE;
27-
Warnings:
28-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t0 and the InnoDB table test.t1.
2927
SET @@debug='+d,injecting_fault_writing';
3028
RENAME TABLES t0 TO t00, t1 TO t01;
3129
ERROR HY000: Error writing file 'binlog' ((errno: #)
@@ -74,8 +72,6 @@ CREATE TABLE t1 (i INT) ENGINE=InnoDB;
7472
CREATE TABLE t0 (l INT) ENGINE=MyISAM;
7573
CREATE DATABASE mysqltest;
7674
LOCK TABLES t0 WRITE, t1 WRITE;
77-
Warnings:
78-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t1 and the MyISAM table test.t0.
7975
SET @@debug='+d,injecting_fault_writing';
8076
RENAME TABLES t0 TO mysqltest.t0, t1 TO t01;
8177
ERROR HY000: Error writing file 'binlog' ((errno: #)

mysql-test/r/rename_myisam.result

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ CREATE TABLE t2 (j INT) ENGINE=InnoDB;
3333
CREATE TABLE t3 (k INT) ENGINE=InnoDB;
3434
CREATE TABLE t4 (l INT) ENGINE=InnoDB;
3535
LOCK TABLES t1 WRITE, t2 WRITE, t3 WRITE, t0 WRITE;
36-
Warnings:
37-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t0 and the InnoDB table test.t1.
3836
RENAME TABLES t0 TO t00, t1 TO t01, t2 TO t4;
3937
ERROR 42S01: Table 't4' already exists
4038
# Tables are available under old names.
@@ -153,8 +151,6 @@ UNLOCK TABLES;
153151
# state of metadata locks too.
154152
# This part of the test resides in rename_myisam.test.
155153
LOCK TABLES t4 WRITE, t1 WRITE;
156-
Warnings:
157-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t1 and the MyISAM table test.t4.
158154
RENAME TABLES t4 TO mysqltest.t4, t1 TO t3;
159155
ERROR 42S01: Table 't3' already exists
160156
# Tables are available under old names.

mysql-test/r/session_tracker_trx_state_myisam.result

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ START TRANSACTION;
6464
INSERT INTO t1 VALUES (1);
6565
# resulting state should be "wW", both safe and unsafe writes happened:
6666
INSERT INTO t2 VALUES (1);
67-
Warnings:
68-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t2 and the InnoDB table test.t1.
6967
# resulting state should STILL be "wW"!
7068
INSERT INTO t1 VALUES (1);
7169
ROLLBACK;
@@ -76,8 +74,6 @@ START TRANSACTION;
7674
INSERT INTO t2 VALUES (1);
7775
# resulting state should be "wW", both safe and unsafe writes happened:
7876
INSERT INTO t1 VALUES (1);
79-
Warnings:
80-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t1 and the MyISAM table test.t2.
8177
# resulting state should be "RwW" (adding transactional read):
8278
SELECT f1 FROM t1;
8379
f1
@@ -139,8 +135,6 @@ CREATE TABLE t1 (f1 INT) ENGINE="InnoDB";
139135
CREATE TABLE t2 (f1 INT) ENGINE="MyISAM";
140136
BEGIN;
141137
COMMIT; INSERT INTO t2 VALUES (1); BEGIN; INSERT INTO t1 VALUES (99); |
142-
Warnings:
143-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t1 and the MyISAM table test.t2.
144138
COMMIT;
145139
DROP TABLE t1;
146140
DROP TABLE t2;
@@ -372,12 +366,8 @@ UNLOCK TABLES;
372366

373367
SET autocommit=1;
374368
LOCK TABLE t1 WRITE, t2 WRITE;
375-
Warnings:
376-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t2 and the InnoDB table test.t1.
377369
INSERT INTO t2 VALUES (3);
378370
INSERT INTO t1 VALUES (3);
379-
Warnings:
380-
Warning 6136 Combining the storage engines InnoDB and MyISAM is deprecated, but the statement or transaction updates both the InnoDB table test.t1 and the MyISAM table test.t2.
381371
SELECT f1 FROM t1 WHERE f1 > 2;
382372
f1
383373
3

mysql-test/r/sp.result

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6109,15 +6109,11 @@ set @a=@a+1;
61096109
return @a;
61106110
end|
61116111
update t2 set b=1 where a=bug27354();
6112-
Warnings:
6113-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t1 and the InnoDB table test.t2.
61146112
select count(t_1.a),count(t_2.a) from t1 as t_1, t2 as t_2 /* must be 0,0 */;
61156113
count(t_1.a) count(t_2.a)
61166114
0 0
61176115
insert into t2 values (1,1),(2,2),(3,3);
61186116
update t2 set b=-b where a=bug27354();
6119-
Warnings:
6120-
Warning 6136 Combining the storage engines MyISAM and InnoDB is deprecated, but the statement or transaction updates both the MyISAM table test.t1 and the InnoDB table test.t2.
61216117
select * from t2 /* must return 1,-1 ... */;
61226118
a b
61236119
1 -1

0 commit comments

Comments
 (0)