Skip to content

Commit 244fa85

Browse files
author
Lavkesh Lahngir
committed
Merge branch 'feastmaster'
2 parents 96aebde + 5508c92 commit 244fa85

File tree

13 files changed

+801
-23
lines changed

13 files changed

+801
-23
lines changed

.prow/scripts/test-end-to-end-batch.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,9 @@ if [[ ${TEST_EXIT_CODE} != 0 ]]; then
255255
echo "[DEBUG] Printing logs"
256256
ls -ltrh /var/log/feast*
257257
cat /var/log/feast-serving-warehouse.log /var/log/feast-core.log
258+
259+
echo "[DEBUG] Printing Python packages list"
260+
pip list
258261
fi
259262

260263
cd ${ORIGINAL_DIR}

.prow/scripts/test-end-to-end.sh

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -67,24 +67,24 @@ tail -n10 /var/log/kafka.log
6767
kafkacat -b localhost:9092 -L
6868

6969
if [[ ${SKIP_BUILD_JARS} != "true" ]]; then
70-
echo "
71-
============================================================
72-
Building jars for Feast
73-
============================================================
74-
"
70+
echo "
71+
============================================================
72+
Building jars for Feast
73+
============================================================
74+
"
7575

76-
.prow/scripts/download-maven-cache.sh \
77-
--archive-uri gs://feast-templocation-kf-feast/.m2.2019-10-24.tar \
78-
--output-dir /root/
76+
.prow/scripts/download-maven-cache.sh \
77+
--archive-uri gs://feast-templocation-kf-feast/.m2.2019-10-24.tar \
78+
--output-dir /root/
7979

80-
# Build jars for Feast
81-
mvn --quiet --batch-mode --define skipTests=true clean package
80+
# Build jars for Feast
81+
mvn --quiet --batch-mode --define skipTests=true clean package
8282

83-
ls -lh core/target/*jar
84-
ls -lh serving/target/*jar
85-
else
86-
echo "[DEBUG] Skipping building jars"
87-
fi
83+
ls -lh core/target/*jar
84+
ls -lh serving/target/*jar
85+
else
86+
echo "[DEBUG] Skipping building jars"
87+
fi
8888

8989
echo "
9090
============================================================
@@ -229,6 +229,9 @@ if [[ ${TEST_EXIT_CODE} != 0 ]]; then
229229
echo "[DEBUG] Printing logs"
230230
ls -ltrh /var/log/feast*
231231
cat /var/log/feast-serving-online.log /var/log/feast-core.log
232+
233+
echo "[DEBUG] Printing Python packages list"
234+
pip list
232235
fi
233236

234237
cd ${ORIGINAL_DIR}

ingestion/pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,5 +248,12 @@
248248
<version>2.8.1</version>
249249
</dependency>
250250

251+
<!-- For calculation of percentiles in feature values -->
252+
<dependency>
253+
<groupId>org.apache.commons</groupId>
254+
<artifactId>commons-math3</artifactId>
255+
<version>3.6.1</version>
256+
</dependency>
257+
251258
</dependencies>
252259
</project>

ingestion/src/main/java/feast/ingestion/options/ImportOptions.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
/** Options passed to Beam to influence the job's execution environment */
2828
public interface ImportOptions extends PipelineOptions, DataflowPipelineOptions, DirectOptions {
29+
2930
@Required
3031
@Description(
3132
"JSON string representation of the FeatureSet that the import job will process, in BZip2 binary format."
@@ -83,4 +84,13 @@ public interface ImportOptions extends PipelineOptions, DataflowPipelineOptions,
8384
int getStatsdPort();
8485

8586
void setStatsdPort(int StatsdPort);
87+
88+
@Description(
89+
"Fixed window size in seconds (default 30) to apply before aggregation of numerical value of features"
90+
+ "and writing the aggregated value to StatsD. Refer to feast.ingestion.transform.metrics.WriteFeatureValueMetricsDoFn"
91+
+ "for details on the metric names and types.")
92+
@Default.Integer(30)
93+
int getWindowSizeInSecForFeatureValueMetric();
94+
95+
void setWindowSizeInSecForFeatureValueMetric(int seconds);
8696
}

0 commit comments

Comments
 (0)